Removed Useless Configuration Options

There are old configuration options that predate time (are older
then islandora has been in GIT) that just don't do anything anymore.
We used to hide them in advanced settings. Just killed them.

.gitignore

@@ -0,0 +1 @@
+nbproject

ObjectHelper.inc

@@ -19,9 +19,7 @@ class ObjectHelper {
   public static $INGEST_FEDORA_OBJECTS = 'ingest new fedora objects';
   public static $EDIT_TAGS_DATASTREAM = 'edit tags datastream';
   public static $VIEW_DETAILED_CONTENT_LIST = 'view detailed list of content';
-  public static $DISPLAY_ALWAYS = 0;
+
-  public static $DISPLAY_NEVER = 1;
-  public static $DISPLAY_NO_MODEL_OUTPUT = 2;
   // TODO: Make this into a static member constant
   public $availableDataStreamsText = 'Detailed list of content';
 
@@ -705,107 +703,6 @@ class ObjectHelper {
     return ($namespace_access && user_access($op, $as_user));
   }
 
-  /**
-   * internal function
-   * uses an xsl to parse the sparql xml returned from the ITQL query
-   * @deprecated
-   *   This is only used in the fedora/repository/collection path, 
-   *   which should probably be nuked.
-   * @param $content String
-   */
-  function parseContent($content, $pid, $dsId, $collection, $pageNumber = NULL) {
-    $path = drupal_get_path('module', 'fedora_repository');
-    global $base_url;
-    $collection_pid = $pid; //we will be changing the pid later maybe
-    $objectHelper = $this;
-    $parsedContent = NULL;
-    $contentModels = $this->get_content_models_list($pid);
-    $isCollection = FALSE;
-
-    $fedoraItem = NULL;
-    $datastreams = $this->get_formatted_datastream_list($pid, $contentModels, $fedoraItem);
-
-    if (!empty($contentModels)) {
-      foreach ($contentModels as $contentModel) {
-        if ($contentModel == variable_get('fedora_collection_model_pid', 'islandora:collectionCModel')) {
-          //if this is a collection object store the $pid in the session as it will come in handy
-          //after a purge or ingest to return to the correct collection.
-
-          $_SESSION['fedora_collection'] = $pid;
-          $isCollection = TRUE;
-        }
-      }
-    }
-
-    if ($fedoraItem !== NULL) {
-      $dslist = $fedoraItem->get_datastreams_list_as_array();
-      if (isset($dslist['COLLECTION_POLICY'])) {
-        $isCollection = TRUE;
-      }
-    }
-    //--------------------------------------------------------------------------------
-    //show the collections datastreams
-    if ($results->length > 0 || $isCollection == TRUE) {
-      //  if(strlen($objectList)>22||$contentModel=='Collection'||$contentModel=='Community')//length of empty dom still equals 22 because of <table/> etc
-      module_load_include('inc', 'fedora_repository', 'CollectionPolicy');
-      $collectionPolicyExists = $this->getMimeType($pid, CollectionPolicy::getDefaultDSID());
-      if (user_access(ObjectHelper::$INGEST_FEDORA_OBJECTS) && $collectionPolicyExists) {
-        if (!empty($collectionPolicyExists)) {
-          $allow = TRUE;
-          if (module_exists('fedora_fesl')) {
-            $allow = fedora_fesl_check_roles($pid, 'write');
-          }
-          if ($allow) {
-            // $ingestObject = '<a title="'. t('Ingest a New object into ') . $collectionName . ' '. $collection_pid . '" href="'. base_path() .
-            $ingest_text = t('Ingest a new object into @collection_name PID @collection_pid', array('@collection_name' => $collectionName, '@collection_pid' => $collection_pid));
-            $ingestObject = l(theme('image', "$path/images/ingest.png", $ingest_text), "fedora/ingestObject/$collection_pid/$collectionName", array('attributes' => array(
-              'class' => 'icon',
-              'title' => $ingest_text,
-            ))) . t('Add to this Collection');
-          }
-        }
-      }
-      else {
-        $ingestObject = '&nbsp;';
-      }
-    }
-
-    $datastreams .= $ingestObject;
-
-
-    $output .= $datastreams;
-
-    $showDesc = FALSE;
-    switch (variable_get('fedora_object_display_description', ObjectHelper :: $DISPLAY_NO_MODEL_OUTPUT)) {
-      case ObjectHelper :: $DISPLAY_NEVER: break;
-      case ObjectHelper :: $DISPLAY_NO_MODEL_OUTPUT:
-        if (trim($datastreams) == '') {
-          $showDesc = TRUE;
-        }
-        break;
-
-      case ObjectHelper :: $DISPLAY_ALWAYS:
-      default:
-        $showDesc = TRUE;
-        break;
-    }
-    if ($showDesc) {
-      //just show default dc or qdc as we could not find a content model
-      $metaDataText = t('Description');
-      $body = $this->getQDC($pid);
-      $fieldset = array(
-        '#title' => t("!metaDataText", array('!metaDataText' => $metaDataText)),
-        '#collapsible' => TRUE,
-        '#collapsed' => TRUE,
-        '#value' => $body
-      );
-      $output .= theme('fieldset', $fieldset);
-    }
-
-
-    return $output;
-  }
-
   /**
    * Get the query to find parent objects.
    *

fedora_repository.module

@@ -62,37 +62,6 @@ function fedora_repository_purge_object($pid = NULL, $name = NULL) {
   return $output;
 }
 
-/**
- * fedora repository collection view
- * @global type $user
- * @param type $pid
- * @param type $collection
- * @param type $pageNumber
- * @return type 
- */
-function fedora_repository_collection_view($pid = NULL, $collection = NULL, $pageNumber = NULL) {
-  module_load_include('inc', 'fedora_repository', 'ObjectHelper');
-  global $user;
-  if (!fedora_repository_access(OBJECTHELPER :: $OBJECT_HELPER_VIEW_FEDORA, $pid, $user)) {
-    drupal_set_message(t("You do not have access to Fedora objects within the attempted namespace or access to Fedora denied."), 'error');
-    return ' ';
-  }
-
-  $objectHelper = new ObjectHelper();
-  if ($pid == NULL) {
-    $pid = variable_get('fedora_repository_pid', 'islandora:root');
-  }
-
-  $content = '';
-
-  module_load_include('inc', 'fedora_repository', 'CollectionClass');
-  $collectionClass = new CollectionClass();
-  $results = $collectionClass->getRelatedItems($pid, NULL);
-  $content .= $objectHelper->parseContent($results, $pid, $dsId, $collection, $pageNumber);
-
-  return $content;
-}
-
 /**
  * fedora repository ingest object
  * @param type $collection_pid

formClass.inc

@@ -123,13 +123,6 @@ class formClass {
       'access arguments' => array('add fedora datastreams')
     );
     
-    $items['fedora/repository/collection'] = array(
-      'title' => t('Collection view'),
-      'page callback' => 'fedora_collection_view',
-      'type' => MENU_CALLBACK,
-      'access argruments' => array('view fedora collection'),
-    );
-    
     //new for mnpl******************************************
     $items['fedora/repository/mnpl_advanced_search'] = array(
       'title' => t('Repository advanced search'),
@@ -347,21 +340,6 @@ class formClass {
       '#collapsible' => TRUE,
       '#collapsed' => TRUE,
     );
-    $form['advanced']['fedora_object_display_title'] = array(
-      '#type' => 'select',
-      '#title' => t('Display Object Title Behaviour'),
-      '#default_value' => variable_get('fedora_object_display_title', ObjectHelper::$DISPLAY_ALWAYS),
-      '#options' => array(ObjectHelper::$DISPLAY_ALWAYS => t('Always'), ObjectHelper::$DISPLAY_NEVER => t('Never'), ObjectHelper::$DISPLAY_NO_MODEL_OUTPUT => t('Only if no Content Model display output.')),
-      '#description' => t('Determines when to display the object (or collection) title when viewing an object/collection page.'),
-    );
-
-    $form['advanced']['fedora_object_display_description'] = array(
-      '#type' => 'select',
-      '#title' => t('Display Object Description Behaviour'),
-      '#default_value' => variable_get('fedora_object_display_description', ObjectHelper::$DISPLAY_ALWAYS),
-      '#options' => array(ObjectHelper::$DISPLAY_ALWAYS => t('Always'), ObjectHelper::$DISPLAY_NEVER => t('Never'), ObjectHelper::$DISPLAY_NO_MODEL_OUTPUT => t('Only if no Content Model display output.')),
-      '#description' => t('Determines when to display the default object (or collection) description fieldset when viewing an object/collection page.'),
-    );
 
     $form['advanced']['fedora_object_restrict_datastreams'] = array(
       '#type' => 'checkbox',
@@ -385,14 +363,6 @@ class formClass {
         )),
     );
     
-    $form['advanced']['fedora_collection_display_list'] = array(
-      '#type' => 'select',
-      '#title' => t('Display Collection List Behaviour'),
-      '#default_value' => variable_get('fedora_collection_display_list', ObjectHelper::$DISPLAY_ALWAYS),
-      '#options' => array(ObjectHelper::$DISPLAY_ALWAYS => t('Always'), ObjectHelper::$DISPLAY_NEVER => t('Never'), ObjectHelper::$DISPLAY_NO_MODEL_OUTPUT => t('Only if no Content Model display output.')),
-      '#description' => t('Determines when to display the list of objects when viewing a collection page.'),
-    );
-    
     $form['advanced']['fedora_control_group_control_during_ingest'] = array(
       '#type' => 'checkbox',
       '#title' => t('Allow control groups select in datastream ingest'),