always saves to the block and fails to evaluate to false. It should not save if
no value has been specified for term URI.
Found the following in `web/core/lib/Drupal/Core/Condition/ConditionPluginCollection.php`.
```php
// In order to determine if a plugin is configured, we must compare it to
// its default configuration. The default configuration of a plugin does
// not contain context_mapping and it is not used when the plugin is not
// configured, so remove the context_mapping from the instance config to
// compare the remaining values.
unset($instance_config['context_mapping']);
if ($default_config === $instance_config) {
unset($configuration[$instance_id]);
}
```
When doing the comparison we have.
```php
$default_config = [
"id" => "node_has_term",
"logic" => "and",
"negate" => false
];
$instance_config = [
"id" => "node_has_term",
"logic" => "and",
"negate" => false,
"uri" => NULL,
];
```
So the comparison fails and the configuration is stored and evaluated later
causing issues since it fails to pass evaluation.
Hence we need to change the default config to match the submitted values.
* update messenger for d9
* fix dependency injection
* update info files
* stream_for updates for d9
* remove deprecated entity query
* replace deprecated functions
* use dependency injection for messenger and fix other deprecated functions for d9
* fix deprecations in tests
* fix test
* phpcs fixes
* fix toUrl method
* properly use StringTranslationTrait
* phpcs fixes and using dependency injection
* more deprecations with upgrade_status 3.x version and more phpcs fixes
* add defaultTheme per https://www.drupal.org/node/3083055
* replace deprecated context definition method - per https://www.drupal.org/node/2976400
* fix context definitions
* remove more deprecations
* fix deprecations in tests
* codesniffer fixes - dependencies must be prefixed with drupal: and missing variable doc comments
* replace more url() -> toUrl() and remove unused variables
* more code sniffer fixes
* some of these urls are necessary as strings
* d9 requires update to flysystem module
* update migrate_source_csv
* temporarily point crayfish-commons to branch with d9 dependencies
* another composer dependency adjustment
* point composer to d9 branch of jsonld
* remove hook_post_action for d9
* remove hook_post_action as a dependency - this does break multifile media FOR NOW
* update migration keys -> ids per https://www.drupal.org/node/3060246
* fix url method
* point jsonld back to dev since PR has been merged
* wrong branch name
* add update hook for change in migration source
* update travis.yml for php 7.4
* add doc comment
* build on php7.2, 7.3, 7.4
* use this instead of Drupal::
* just php 7.3 and 7.4
* swap back to dev-dev crayfish-commons since PR was merged
* perhaps this fixes the config thing
* trying to fix config
* ugh errant semicolon
* missing variable name
* maybe it would help if i named the variables consistently
* please work...
* i can't get the dependency injection of config correct
* sad panda
* thanks @seth-shaw-unlv for this magical fix
* fix dependency injection
* putting the config in the AbstractGenerateDerivativeMediaFile class instead
* already the system.file config
* update test module info file
* fix implode ordre of parameters
* remove unused use statement
* fix geminiclient tests
* phpcs fix
* check for fedora key in flysystem
* check for array not being null
* more null checks
* try on the downgrade-symfony branch
* set fedora url to null if it isn't in the settings
* testing the crayfish-commons version fix
* fixes for new classes in newer version of guzzlehttp but still needing to support old methods
* update phpunit.xml?
* transform 1 response from preg_match to a boolean
* reorder crayfish-commons version fix
* code sniffer fixes
* abstract awaying the shared constructor so that phpcpd is happy about less duplicated code
* attempt to reduce shared code in the FedoraAdapterTest
* remove unused use statement
* code sniffer fixes...not sure how i missed these...
* remove reliance on branch of crayfish-commons since PR has been merged
* Work on #1491.
* Work in #1491, incorporating @jordandukart 's suggestion.
* Fixed code style errors.
* Removed superfluous code.
* Fixed WSODs and warnings.
* Empty commit to trigger a build.
* Replace two logic checks with one.
Nigel Banks