Original code passed with flying colors using Code Review module. Ran it
through PHP_CodeSniffer and it found a crazy amount of errors.
Should be fixed now though.
A SimpleTest file has also been included to allow you to test this file
for errors.
Please note the require once directive at the top of
tests/MimeClass.test. I am not sure if this is Drupal kosher, but the
test wouldn't work without it.
There is probably a way around this include statement but I will leave
this to the Drupal experts.
Note that the Drupal 7 function file_mimetype_mapping has a Drupal alter
statement:
// Allow modules to alter the default mapping.
drupal_alter('file_mimetype_mapping', $mapping);
using this hook, you can add to this internal mime type list without
updating drupal core.
Hope this helps! If there are any questions please feel free to email me
at andrewfreddin@gmail.com
File naming conventions now state that all PHP files (except templates) should
be lower-case and use underscores to separate words in a filename.
includes/IslandoraTuque.inc, and includes/IslandoraTuqueWrapper.inc are not
included in this commit as there is another pull request that corrects their
names in place, and we would like to avoid merge conflicts.
hook_islandora_object_alter(AbstractFedoraObject $object, array &$context)
hook_CMODEL_PID_islandora_object_alter(AbstractFedoraObject $object, array &$context)
hook_islandora_datastream_alter(AbstractFedoraObject $object, AbstractFedoraDatastream $datastream, array &$context)
hook_CMODEL_PID_DSID_islandora_datastream_altezr(AbstractFedoraObject $object, AbstractFedoraDatastream $datastream, array &$context)
hook_islandora_object_ingested(FedoraObject $object)
hook_CMODEL_PID_islandora_object_ingested(FedoraObject $object)
hook_islandora_object_modified(FedoraObject $object)
hook_CMODEL_PID_islandora_object_modified(FedoraObject $object)
hook_islandora_object_purged($pid)
hook_CMODEL_PID_islandora_object_purged($pid)
hook_islandora_datastream_ingested(FedoraObject $object, FedoraDatastream $datastream)
hook_CMODEL_PID_DSID_islandora_datastream_ingested(FedoraObject $object, FedoraDatastream $datastream)
hook_islandora_datastream_modified(FedoraObject $object, FedoraDatastream $datastream)
hook_CMODEL_PID_islandora_datastream_modified(FedoraObject $object, FedoraDatastream $datastream)
hook_islandora_datastream_purged(FedoraObject $object, $dsid)
hook_CMODEL_PID_islandora_datastream_purged(FedoraObject $object, $dsid)
Also updated the testing scripts to support different configurations, as well
wrote tests for all the implemented hooks. This requires the latest version
of Tuque so be sure to update.
The table printed by solution_packs.inc used to not mention
which datastreams were modified. We do that now.
We also test the MD5 of the datastream to make sure that it is
actually the same.
... Was not rebuilding the list of steps before trying to select the
next, so some odd behaviour was occuring--going back to the first step,
due to the current step_id no longer existing.