codesniffer fixes - dependencies must be prefixed with drupal: and missing variable doc comments

4 years ago · de4fcbb00c
11 changed files with 73 additions and 65 deletions
--- a/islandora.info.yml
+++ b/islandora.info.yml
@ -7,30 +7,30 @@ package: Islandora
 core: 8.x
 core_version_requirement: ^8 || ^9
 dependencies:
-  - block
-  - node
-  - path
-  - text
-  - options
-  - link
-  - jsonld
-  - search_api
-  - jwt
-  - rest
-  - filehash
-  - basic_auth
-  - context_ui
-  - action
-  - eva
-  - taxonomy
-  - views_ui
-  - media
-  - prepopulate
-  - features_ui
-  - migrate_tools
-  - migrate_source_csv
-  - content_translation
-  - flysystem
-  - token
-  - hook_post_action
-  - file_replace
+  - drupal:block
+  - drupal:node
+  - drupal:path
+  - drupal:text
+  - drupal:options
+  - drupal:link
+  - drupal:jsonld
+  - drupal:search_api
+  - drupal:jwt
+  - drupal:rest
+  - drupal:filehash
+  - drupal:basic_auth
+  - drupal:context_ui
+  - drupal:action
+  - drupal:eva
+  - drupal:taxonomy
+  - drupal:views_ui
+  - drupal:media
+  - drupal:prepopulate
+  - drupal:features_ui
+  - drupal:migrate_tools
+  - drupal:migrate_source_csv
+  - drupal:content_translation
+  - drupal:flysystem
+  - drupal:token
+  - drupal:hook_post_action
+  - drupal:file_replace
--- a/modules/islandora_audio/islandora_audio.info.yml
+++ b/modules/islandora_audio/islandora_audio.info.yml
@ -5,4 +5,4 @@ package: Islandora
 core: 8.x
 core_version_requirement: ^8 || ^9
 dependencies:
-  - islandora
+  - drupal:islandora
--- a/modules/islandora_breadcrumbs/islandora_breadcrumbs.info.yml
+++ b/modules/islandora_breadcrumbs/islandora_breadcrumbs.info.yml
@ -5,4 +5,4 @@ core: 8.x
 core_version_requirement: ^8 || ^9
 package: Islandora
 dependencies:
-  - islandora
+  - drupal:islandora
--- a/modules/islandora_core_feature/islandora_core_feature.info.yml
+++ b/modules/islandora_core_feature/islandora_core_feature.info.yml
@ -4,26 +4,26 @@ type: module
 core: 8.x
 core_version_requirement: ^8 || ^9
 dependencies:
-  - basic_auth
-  - content_translation
-  - eva
-  - features
-  - field
-  - file
-  - filehash
-  - image
-  - islandora
-  - jsonld
-  - jwt
-  - language
-  - link
-  - media
-  - migrate_plus
-  - node
-  - rest
-  - serialization
-  - system
-  - taxonomy
-  - user
-  - views
+  - drupal:basic_auth
+  - drupal:content_translation
+  - drupal:eva
+  - drupal:features
+  - drupal:field
+  - drupal:file
+  - drupal:filehash
+  - drupal:image
+  - drupal:islandora
+  - drupal:jsonld
+  - drupal:jwt
+  - drupal:language
+  - drupal:link
+  - drupal:media
+  - drupal:migrate_plus
+  - drupal:node
+  - drupal:rest
+  - drupal:serialization
+  - drupal:system
+  - drupal:taxonomy
+  - drupal:user
+  - drupal:views
 package: Islandora
--- a/modules/islandora_iiif/islandora_iiif.info.yml
+++ b/modules/islandora_iiif/islandora_iiif.info.yml
@ -5,4 +5,4 @@ core: 8.x
 core_version_requirement: ^8 || ^9
 package: Islandora
 dependencies:
-  - islandora
+  - drupal:islandora
--- a/modules/islandora_image/islandora_image.info.yml
+++ b/modules/islandora_image/islandora_image.info.yml
@ -5,4 +5,4 @@ core: 8.x
 core_version_requirement: ^8 || ^9
 package: Islandora
 dependencies:
-  - islandora
+  - drupal:islandora
--- a/modules/islandora_text_extraction/islandora_text_extraction.info.yml
+++ b/modules/islandora_text_extraction/islandora_text_extraction.info.yml
@ -5,4 +5,4 @@ core: 8.x
 core_version_requirement: ^8 || ^9
 package: 'Islandora'
 dependencies:
-  - islandora
+  - drupal:islandora
--- a/modules/islandora_text_extraction_defaults/islandora_text_extraction_defaults.info.yml
+++ b/modules/islandora_text_extraction_defaults/islandora_text_extraction_defaults.info.yml
@ -5,13 +5,13 @@ core: 8.x
 core_version_requirement: ^8 || ^9
 package: Islandora
 dependencies:
-  - field
-  - file
-  - islandora_core_feature
-  - islandora_text_extraction
-  - language
-  - media
-  - path
-  - system
-  - text
-  - user
+  - drupal:field
+  - drupal:file
+  - drupal:islandora_core_feature
+  - drupal:islandora_text_extraction
+  - drupal:language
+  - drupal:media
+  - drupal:path
+  - drupal:system
+  - drupal:text
+  - drupal:user
--- a/modules/islandora_video/islandora_video.info.yml
+++ b/modules/islandora_video/islandora_video.info.yml
@ -5,4 +5,4 @@ package: Islandora
 core: 8.x
 core_version_requirement: ^8 || ^9
 dependencies:
-  - islandora
+  - drupal:islandora
--- a/tests/src/Functional/IslandoraFunctionalTestBase.php
+++ b/tests/src/Functional/IslandoraFunctionalTestBase.php
@ -32,6 +32,9 @@ class IslandoraFunctionalTestBase extends BrowserTestBase {
    'menu_link_content',
  ];

+  /**
+   * {@inheritdoc}
+   */
  protected $defaultTheme = 'stark';

  /**
--- a/tests/src/FunctionalJavascript/IntegerWeightTest.php
+++ b/tests/src/FunctionalJavascript/IntegerWeightTest.php
@ -32,6 +32,11 @@ class IntegerWeightTest extends WebDriverTestBase {
    'integer_weight_test_views',
  ];

+  /**
+   * Name of theme.
+   *
+   * @var string
+   */
  protected $defaultTheme = 'stark';

  /**