Browse Source

Coder

pull/720/head
Jared Whiklo 5 years ago
parent
commit
525283cb9c
  1. 2
      README.md
  2. 8
      includes/tuque_wrapper.inc
  3. 12
      islandora.install
  4. 2
      islandora.module

2
README.md

@ -69,8 +69,6 @@ Further documentation for this module is available at [our documentation wiki](h
## Troubleshooting/Issues
NOTE: There has been a function signature change for the `ingestDatastream` function within Tuque which will be deprecated after the 7.x-1.10 release. To read about it in detail please see the [JIRA ticket](https://jira.duraspace.org/browse/ISLANDORA-1995). For the time being there is a warning stating that this will become deprecated and that code that utilizes this specific behavior should be updated. Once this code is updated the `islandora_deprecation_return_false_when_datastream_exists` variable may be set to FALSE so the warning no longer displays. An example for doing this with drush: `drush vset islandora_deprecation_return_false_when_datastream_exists FALSE`.
Having problems or solved a problem? Check out the Islandora google groups for a solution.
* [Islandora Group](https://groups.google.com/forum/?hl=en&fromgroups#!forum/islandora)

8
includes/tuque_wrapper.inc

@ -253,14 +253,6 @@ class IslandoraFedoraObject extends FedoraObject {
return $ret;
}
catch (Exception $e) {
if ($e instanceof DatastreamExistsException && variable_get('islandora_deprecation_return_false_when_datastream_exists', TRUE)) {
$message = format_string('The datastream @dsid already exists on the object: @pid. As of 7.x-1.10 the function signature for ingestDatastream will be changed from returning FALSE on failure to throwing an exception.', array(
'@dsid' => $datastream->id,
'@pid' => $object->id,
));
trigger_error(filter_xss($message), E_USER_DEPRECATED);
return FALSE;
}
watchdog('islandora', 'Failed to ingest datastream @dsid on object: @pid</br>code: @code<br/>message: @msg', array(
'@pid' => $object->id,
'@dsid' => $datastream->id,

12
islandora.install

@ -133,3 +133,15 @@ function islandora_update_7001(&$sandbox) {
$t = get_t();
return $t("Islandora database updates complete");
}
/**
* Implements hook_update_N().
*
* Removing old variable around changes to ingestDatastream signature.
* These changes are complete and deprecation warnings are removed.
*/
function islandora_update_7002() {
// Removing as the deprecation has been removed.
variable_del('islandora_deprecation_return_false_when_datastream_exists');
}

2
islandora.module

@ -663,7 +663,7 @@ function islandora_i18n_string_info() {
}
/**
* Implements islandora_i18n_string_list().
* Implements hook_i18n_string_list().
*/
function islandora_i18n_string_list($group) {
if ($group == 'islandora') {

Loading…
Cancel
Save