Code
/
islandora
7
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity
Drupal modules for browsing and managing Fedora-based digital repositories.
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
436 Commits
37 Branches
80 Tags
23 MiB
Tree: 1415bd509b
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '1415bd509b'
${ noResults }
islandora/.github/PULL_REQUEST_TEMPLATE.md

44 lines
1.4 KiB
Raw Normal View History Unescape

Pull Request Template (#45)
8 years ago
**GitHub Issue**: (link)
Add JWT Token Authentication (#38) * Add JWT Token Authentication This adds JWT token authentication to Islandora. We send these tokens along with broadcast messages, and can use them to authenticate with Fedora as well as call back into Islandora. * Updated the version for JWT in the composer file. * JwtEventSubscriber tests. * Fixing copy/pasta mistake in tests (#2) * Update JWT Structure to Eliminate Nesting No java JWT parsing libraries like when a JWT contains nested structures, even when that is allowed in the standard. This commit updates our code so we put the drupal data at the root level of the JWT claims, instead of in a subclaim. * Coding standards for new sniffs
8 years ago
* Other Relevant Links (Google Groups discussion, related pull requests,
Release pull requests, etc.)
Pull Request Template (#45)
8 years ago
# What does this Pull Request do?
Add JWT Token Authentication (#38) * Add JWT Token Authentication This adds JWT token authentication to Islandora. We send these tokens along with broadcast messages, and can use them to authenticate with Fedora as well as call back into Islandora. * Updated the version for JWT in the composer file. * JwtEventSubscriber tests. * Fixing copy/pasta mistake in tests (#2) * Update JWT Structure to Eliminate Nesting No java JWT parsing libraries like when a JWT contains nested structures, even when that is allowed in the standard. This commit updates our code so we put the drupal data at the root level of the JWT claims, instead of in a subclaim. * Coding standards for new sniffs
8 years ago
A brief description of what the intended result of the PR will be and/or what
problem it solves.
Pull Request Template (#45)
8 years ago
# What's new?
Add JWT Token Authentication (#38) * Add JWT Token Authentication This adds JWT token authentication to Islandora. We send these tokens along with broadcast messages, and can use them to authenticate with Fedora as well as call back into Islandora. * Updated the version for JWT in the composer file. * JwtEventSubscriber tests. * Fixing copy/pasta mistake in tests (#2) * Update JWT Structure to Eliminate Nesting No java JWT parsing libraries like when a JWT contains nested structures, even when that is allowed in the standard. This commit updates our code so we put the drupal data at the root level of the JWT claims, instead of in a subclaim. * Coding standards for new sniffs
8 years ago
A in-depth description of the changes made by this PR. Technical details and
possible side effects.
Pull Request Template (#45)
8 years ago
* Changes x feature to such that y
* Added x
* Removed y
* Does this change add any new dependencies?
Add JWT Token Authentication (#38) * Add JWT Token Authentication This adds JWT token authentication to Islandora. We send these tokens along with broadcast messages, and can use them to authenticate with Fedora as well as call back into Islandora. * Updated the version for JWT in the composer file. * JwtEventSubscriber tests. * Fixing copy/pasta mistake in tests (#2) * Update JWT Structure to Eliminate Nesting No java JWT parsing libraries like when a JWT contains nested structures, even when that is allowed in the standard. This commit updates our code so we put the drupal data at the root level of the JWT claims, instead of in a subclaim. * Coding standards for new sniffs
8 years ago
* Does this change require any other modifications to be made to the repository
Ran Aspell CLI spell checker (#178) I used an Aspell "word list" based on the "word list" from the ISLE repo found here... https://raw.githubusercontent.com/Islandora-Collaboration-Group/ISLE/master/.aspell.en.pws
5 years ago
(i.e. Regeneration activity, etc.)?
Pull Request Template (#45)
8 years ago
* Could this change impact execution of existing code?
# How should this be tested?
A description of what steps someone could take to:
* Reproduce the problem you are fixing (if applicable)
* Test that the Pull Request does what is intended.
* Please be as detailed as possible.
* Good testing instructions help get your PR completed faster.
Add "Documentation" section to pull request template (#846) * Update PULL_REQUEST_TEMPLATE.md * fix spelling.
3 years ago
# Documentation Status
* Does this change existing behaviour that's currently documented?
* Does this change require new pages or sections of documentation?
* Who does this need to be documented for?
* Associated documentation pull request(s): ___ or documentation issue ___
Pull Request Template (#45)
8 years ago
# Additional Notes:
Add JWT Token Authentication (#38) * Add JWT Token Authentication This adds JWT token authentication to Islandora. We send these tokens along with broadcast messages, and can use them to authenticate with Fedora as well as call back into Islandora. * Updated the version for JWT in the composer file. * JwtEventSubscriber tests. * Fixing copy/pasta mistake in tests (#2) * Update JWT Structure to Eliminate Nesting No java JWT parsing libraries like when a JWT contains nested structures, even when that is allowed in the standard. This commit updates our code so we put the drupal data at the root level of the JWT claims, instead of in a subclaim. * Coding standards for new sniffs
8 years ago
Any additional information that you think would be helpful when reviewing this
PR.
Pull Request Template (#45)
8 years ago
# Interested parties
De-CLAWing
5 years ago
Tag (@ mention) interested parties or, if unsure, @Islandora/8-x-committers