From c6beca5ae8b1fea0453f23b5885f21befb526479 Mon Sep 17 00:00:00 2001 From: Nelson Hart Date: Wed, 4 Sep 2013 09:17:07 -0300 Subject: [PATCH 01/45] allow mulitple mime types for viewers --- includes/solution_packs.inc | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/includes/solution_packs.inc b/includes/solution_packs.inc index 7cf0351a..337f76c4 100644 --- a/includes/solution_packs.inc +++ b/includes/solution_packs.inc @@ -679,11 +679,17 @@ function islandora_viewers_form($variable_id = NULL, $mimetype = NULL, $model = function islandora_get_viewers($mimetype = NULL, $content_model = NULL) { $viewers = array(); $defined_viewers = module_invoke_all('islandora_viewer_info'); + + if(!is_array($mimetype)) { + $mimetype = array($mimetype); + } + // Filter viewers by MIME type. foreach ($defined_viewers as $key => $value) { $value['mimetype'] = isset($value['mimetype']) ? $value['mimetype'] : array(); $value['model'] = isset($value['model']) ? $value['model'] : array(); - if (in_array($mimetype, $value['mimetype']) OR in_array($content_model, $value['model'])) { + if (array_intersect($mimetype, $value['mimetype']) OR in_array($content_model, $value['model'])) { + //if (in_array($mimetype, $value['mimetype']) OR in_array($content_model, $value['model'])) { $viewers[$key] = $value; } } From f486133fbbe72869ee50fe86eb965a85091cab25 Mon Sep 17 00:00:00 2001 From: Nelson Hart Date: Wed, 12 Feb 2014 10:44:56 -0400 Subject: [PATCH 02/45] remove comment --- includes/solution_packs.inc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/includes/solution_packs.inc b/includes/solution_packs.inc index 30cc8576..6f4b4ae3 100644 --- a/includes/solution_packs.inc +++ b/includes/solution_packs.inc @@ -256,7 +256,7 @@ function islandora_solution_pack_form_submit(array $form, array &$form_state) { * the batch. * @param array $not_checked * The object that will bot be install. - * + * * @return array * An array defining a batch which can be passed on to batch_set(). */ @@ -735,7 +735,6 @@ function islandora_get_viewers($mimetype = NULL, $content_model = NULL) { $value['mimetype'] = isset($value['mimetype']) ? $value['mimetype'] : array(); $value['model'] = isset($value['model']) ? $value['model'] : array(); if (array_intersect($mimetype, $value['mimetype']) OR in_array($content_model, $value['model'])) { - //if (in_array($mimetype, $value['mimetype']) OR in_array($content_model, $value['model'])) { $viewers[$key] = $value; } } From 3bdd909e15d5f3b340d3d97aff8fac0426782d21 Mon Sep 17 00:00:00 2001 From: Nelson Hart Date: Wed, 12 Feb 2014 10:49:42 -0400 Subject: [PATCH 03/45] docs update for array of mime types --- includes/solution_packs.inc | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/includes/solution_packs.inc b/includes/solution_packs.inc index 6f4b4ae3..0ff7d253 100644 --- a/includes/solution_packs.inc +++ b/includes/solution_packs.inc @@ -712,9 +712,8 @@ function islandora_viewers_form($variable_id = NULL, $mimetype = NULL, $model = * given, than any viewer that supports either the give $mimetype or $model will * be listed. * - * @param string $mimetype - * Specify a mimetype to return only viewers that support this certain - * mimetype. + * @param array $mimetype + * List of mimetypes that the view supports. * @param string $content_model * Specify a content model to return only viewers that support the content * model. @@ -722,7 +721,7 @@ function islandora_viewers_form($variable_id = NULL, $mimetype = NULL, $model = * @return array * Viewer definitions, or FALSE if none are found. */ -function islandora_get_viewers($mimetype = NULL, $content_model = NULL) { +function islandora_get_viewers($mimetype = array(), $content_model = NULL) { $viewers = array(); $defined_viewers = module_invoke_all('islandora_viewer_info'); From ecb4f09766176fcc0564916f9f046afdf09adea2 Mon Sep 17 00:00:00 2001 From: Nelson Hart Date: Wed, 12 Feb 2014 10:50:43 -0400 Subject: [PATCH 04/45] spelling --- includes/solution_packs.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/solution_packs.inc b/includes/solution_packs.inc index 0ff7d253..d875bc69 100644 --- a/includes/solution_packs.inc +++ b/includes/solution_packs.inc @@ -713,7 +713,7 @@ function islandora_viewers_form($variable_id = NULL, $mimetype = NULL, $model = * be listed. * * @param array $mimetype - * List of mimetypes that the view supports. + * List of mimetypes that the viewer supports. * @param string $content_model * Specify a content model to return only viewers that support the content * model. From 656d2b13058ada19e0a9a7dd670a0826dcf4370e Mon Sep 17 00:00:00 2001 From: Nelson Hart Date: Thu, 13 Feb 2014 14:58:37 -0400 Subject: [PATCH 05/45] cs fixes --- includes/solution_packs.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/solution_packs.inc b/includes/solution_packs.inc index d875bc69..0209ecbd 100644 --- a/includes/solution_packs.inc +++ b/includes/solution_packs.inc @@ -725,7 +725,7 @@ function islandora_get_viewers($mimetype = array(), $content_model = NULL) { $viewers = array(); $defined_viewers = module_invoke_all('islandora_viewer_info'); - if(!is_array($mimetype)) { + if (!is_array($mimetype)) { $mimetype = array($mimetype); } From b42d9c5920e3cea7ed315b1e1a3be67ea06b3a7d Mon Sep 17 00:00:00 2001 From: Jordan Dukart Date: Tue, 25 Feb 2014 18:14:01 +0000 Subject: [PATCH 06/45] Change the default view to utilize the new metadata framework. --- includes/datastream.version.inc | 2 +- includes/manage_deleted_objects.inc | 8 +++---- theme/islandora-object.tpl.php | 36 ++++++++++++----------------- theme/theme.inc | 7 ++++++ 4 files changed, 27 insertions(+), 26 deletions(-) diff --git a/includes/datastream.version.inc b/includes/datastream.version.inc index 8c02aaad..ecef019d 100644 --- a/includes/datastream.version.inc +++ b/includes/datastream.version.inc @@ -234,7 +234,7 @@ function islandora_revert_datastream_version_form_submit(array $form, array &$fo /** * Gets Audit datastream values from foxml. * - * @param String $pid + * @param string $pid * PID of parent object * * @return array diff --git a/includes/manage_deleted_objects.inc b/includes/manage_deleted_objects.inc index 2708efe3..a6b5e96e 100644 --- a/includes/manage_deleted_objects.inc +++ b/includes/manage_deleted_objects.inc @@ -287,7 +287,7 @@ function islandora_get_contentmodels_with_deleted_members() { /** * Restores deleted object. * - * @param String $pid + * @param string $pid * PID of object to be restored */ function islandora_restore_object_by_pid($pid) { @@ -298,7 +298,7 @@ function islandora_restore_object_by_pid($pid) { /** * Purges deleted object. * - * @param String $pid + * @param string $pid * PID of object to be restored */ function islandora_purge_object_by_pid($pid) { @@ -314,7 +314,7 @@ function islandora_purge_object_by_pid($pid) { * @param int $offset * offset to be added to search * - * @return String + * @return string * Sparql query */ function islandora_get_deleted_query($content_models, $offset = 0) { @@ -332,7 +332,7 @@ function islandora_get_deleted_query($content_models, $offset = 0) { $unions .= "UNION {?subject fm:hasModel ; fm:state fm:Deleted; fm:hasModel ?object; - } + } "; } $optional = "OPTIONAL{?subject fm:label ?label}"; diff --git a/theme/islandora-object.tpl.php b/theme/islandora-object.tpl.php index 6fa306c3..fdd09607 100644 --- a/theme/islandora-object.tpl.php +++ b/theme/islandora-object.tpl.php @@ -60,7 +60,7 @@ ?>

- +
@@ -68,26 +68,10 @@
-
- - $value): ?> -
- -
-
- -
- - - -
Collections
-
- -
label, "islandora/object/{$collection->id}"); ?>
- -
- -
+
+ + +
+ +
+

+
    + +
  • label, "islandora/object/{$collection->id}"); ?>
    • + +
+
+ diff --git a/theme/theme.inc b/theme/theme.inc index b783cfa8..7e54fefd 100644 --- a/theme/theme.inc +++ b/theme/theme.inc @@ -109,6 +109,7 @@ function islandora_preprocess_islandora_default(&$variables) { $islandora_object = $variables['islandora_object']; module_load_include('inc', 'islandora', 'includes/utilities'); module_load_include('inc', 'islandora', 'includes/datastream'); + module_load_include('inc', 'islandora', 'includes/metadata'); $variables['parent_collections'] = islandora_get_parents_from_rels_ext($islandora_object); @@ -140,8 +141,14 @@ function islandora_preprocess_islandora_default(&$variables) { $dc_object = DublinCore::importFromXMLString($islandora_object['DC']->content); $dc_array = $dc_object->asArray(); } + // We should eventually remove the DC object and dc_array code as it only + // exists to not break legacy implementations. $variables['dc_array'] = isset($dc_array) ? $dc_array : array(); $variables['islandora_dublin_core'] = isset($dc_object) ? $dc_object : NULL; + + $variables['parent_collections'] = islandora_get_parents_from_rels_ext($islandora_object); + $variables['metadata'] = islandora_retrieve_metadata_markup($islandora_object, TRUE); + $variables['description'] = islandora_retrieve_description_markup($islandora_object); $variables['islandora_object_label'] = $islandora_object->label; if (isset($islandora_object['TN']) && islandora_datastream_access(ISLANDORA_VIEW_OBJECTS, $islandora_object['TN'])) { $variables['islandora_thumbnail_url'] = url("islandora/object/{$islandora_object->id}/datastream/TN/view"); From f8b63e6110a168c76d0484524533dbffe5b6f28d Mon Sep 17 00:00:00 2001 From: Jordan Dukart Date: Tue, 25 Feb 2014 18:20:19 +0000 Subject: [PATCH 07/45] Re-added a variable already defined. --- theme/theme.inc | 1 - 1 file changed, 1 deletion(-) diff --git a/theme/theme.inc b/theme/theme.inc index 7e54fefd..feac06b2 100644 --- a/theme/theme.inc +++ b/theme/theme.inc @@ -146,7 +146,6 @@ function islandora_preprocess_islandora_default(&$variables) { $variables['dc_array'] = isset($dc_array) ? $dc_array : array(); $variables['islandora_dublin_core'] = isset($dc_object) ? $dc_object : NULL; - $variables['parent_collections'] = islandora_get_parents_from_rels_ext($islandora_object); $variables['metadata'] = islandora_retrieve_metadata_markup($islandora_object, TRUE); $variables['description'] = islandora_retrieve_description_markup($islandora_object); $variables['islandora_object_label'] = $islandora_object->label; From ee89aaaaa3a0ea18668ac4cc84aa9c97ec01ce77 Mon Sep 17 00:00:00 2001 From: Jordan Dukart Date: Tue, 25 Feb 2014 18:23:04 +0000 Subject: [PATCH 08/45] Add a class that may be needed. --- theme/islandora-dublin-core-display.tpl.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/theme/islandora-dublin-core-display.tpl.php b/theme/islandora-dublin-core-display.tpl.php index 2c2a02ee..52c80607 100644 --- a/theme/islandora-dublin-core-display.tpl.php +++ b/theme/islandora-dublin-core-display.tpl.php @@ -17,7 +17,7 @@
>
-
+
$value): ?>
From 999a98c7206002bed65d6d8bd161c42b5429f27f Mon Sep 17 00:00:00 2001 From: Nigel Banks Date: Thu, 6 Mar 2014 16:14:39 -0400 Subject: [PATCH 09/45] Updated documentation to reflect the actual behavoir of the code. --- islandora.api.php | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/islandora.api.php b/islandora.api.php index 0534ffe7..e8b45ba7 100644 --- a/islandora.api.php +++ b/islandora.api.php @@ -472,7 +472,7 @@ function hook_islandora_ingest_steps(array $form_state) { * * @param array $steps * An array of steps as generated by hook_islandora_ingest_steps(). - * + * * @param array $form_state * An array containing the Drupal form_state. */ @@ -497,7 +497,7 @@ function hook_CMODEL_PID_islandora_ingest_steps(array $form_state) { * * @param array $steps * An array of steps as generated by hook_islandora_ingest_steps(). - * + * * @param array $form_state * An array containing the Drupal form_state. */ @@ -638,7 +638,8 @@ function hook_CMODEL_PID_islandora_overview_object_alter(AbstractObject &$object * module_name_derivative_creation_function($object, $force = FALSE) * These functions must return an array in the structure of: * - success: Bool denoting whether the operation was successful. - * - messages: An array structure containing: + * - messages: An array structure containing zero or more array's with the + * following fields: * - message: A string passed through t() describing the * outcome of the operation. * - message_sub: (Optional) Substitutions to be passed along to t() or @@ -704,7 +705,7 @@ function hook_CMODEL_PID_islandora_derivative() { function hook_islandora_update_related_objects_properties(AbstractObject $object) { $related_objects = get_all_children_siblings_and_friends($object); $pids_to_return = array(); - foreach($related_objects as $related_object) { + foreach ($related_objects as $related_object) { $pids_to_return[] = $related_object->id; } return $pids_to_return; From 0755a52aa122f4bd18ec8be6930a5e1d9062b120 Mon Sep 17 00:00:00 2001 From: nruest Date: Sun, 16 Mar 2014 21:19:21 -0400 Subject: [PATCH 10/45] Fix ISLANDORA-832 --- includes/admin.form.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/admin.form.inc b/includes/admin.form.inc index b0bb0642..3dc97091 100644 --- a/includes/admin.form.inc +++ b/includes/admin.form.inc @@ -27,7 +27,7 @@ function islandora_repository_admin(array $form, array &$form_state) { '#type' => 'vertical_tabs', 'islandora_general' => array( '#type' => 'fieldset', - '#title' => t('General Configuarion'), + '#title' => t('General Configuration'), 'wrapper' => array( '#prefix' => '
', '#suffix' => '
', From adc63e61565a59521308986a04b6f8a697d91ef2 Mon Sep 17 00:00:00 2001 From: Jordan Dukart Date: Fri, 21 Mar 2014 18:13:56 +0000 Subject: [PATCH 11/45] Update README and create XACMLs for anonymous ingestion. --- README.md | 11 +++++-- policies/permit-apim-to-anonymous-user.xml | 31 ++++++++++++++++++++ policies/permit-upload-to-anonymous-user.xml | 31 ++++++++++++++++++++ 3 files changed, 70 insertions(+), 3 deletions(-) create mode 100644 policies/permit-apim-to-anonymous-user.xml create mode 100644 policies/permit-upload-to-anonymous-user.xml diff --git a/README.md b/README.md index 90d935cf..371797b2 100644 --- a/README.md +++ b/README.md @@ -42,11 +42,16 @@ INSTALLATION Before installing Islandora the XACML policies located in the policies folder should be copied into the Fedora global XACML policies folder. This will allow -"authenticated users" in Drupal to access Fedora API-M functions. +"authenticated users" in Drupal to access Fedora API-M functions. It is to be +noted that the permit-upload-to-anonymous-user.xml and +permit-apim-to-anonymous-user.xml files do not need to be present unless +requirements for anonymous ingesting are present. -You will also have to remove some default policies if you want full functionality as well. +You will also have to remove some default policies if you want full +functionality as well. -Remove deny-purge-datastream-if-active-or-inactive.xml to allow for purging of datastream versions. +Remove deny-purge-datastream-if-active-or-inactive.xml to allow for purging of +datastream versions. CONFIGURATION ------------- diff --git a/policies/permit-apim-to-anonymous-user.xml b/policies/permit-apim-to-anonymous-user.xml new file mode 100644 index 00000000..4fc711f5 --- /dev/null +++ b/policies/permit-apim-to-anonymous-user.xml @@ -0,0 +1,31 @@ + + + note that other policies may provide exceptions to this broad policy. This policy assumes api-m users have to be authenticated + + + + + anonymous user + + + + + + + + + + + urn:fedora:names:fedora:2.1:action:api-m + + + + + + + diff --git a/policies/permit-upload-to-anonymous-user.xml b/policies/permit-upload-to-anonymous-user.xml new file mode 100644 index 00000000..bebcd37b --- /dev/null +++ b/policies/permit-upload-to-anonymous-user.xml @@ -0,0 +1,31 @@ + + + + + + + + anonymous user + + + + + + + + + + + urn:fedora:names:fedora:2.1:action:id-upload + + + + + + + From 90c60eda0ede3616922e5d4dfd9854efc81884fd Mon Sep 17 00:00:00 2001 From: willtp87 Date: Wed, 2 Apr 2014 15:30:06 -0300 Subject: [PATCH 12/45] rules integration during ingest --- includes/tuque_wrapper.inc | 4 ++++ islandora.rules.inc | 23 ++++++++++++++++++++--- islandora.rules_defaults.inc | 26 ++++++++++++++++++++++++++ 3 files changed, 50 insertions(+), 3 deletions(-) create mode 100644 islandora.rules_defaults.inc diff --git a/includes/tuque_wrapper.inc b/includes/tuque_wrapper.inc index d30af147..573d7c62 100644 --- a/includes/tuque_wrapper.inc +++ b/includes/tuque_wrapper.inc @@ -115,6 +115,10 @@ class IslandoraFedoraRepository extends FedoraRepository { foreach ($object as $dsid => $datastream) { islandora_invoke_datastream_hooks(ISLANDORA_DATASTREAM_INGESTED_HOOK, $object->models, $dsid, $object, $datastream); } + // Fire of event if rules is enabled. + if (module_exists('rules')) { + rules_invoke_event('islandora_object_ingested', $object); + } return $ret; } catch (Exception $e) { diff --git a/islandora.rules.inc b/islandora.rules.inc index 4045b1b9..02f5c822 100644 --- a/islandora.rules.inc +++ b/islandora.rules.inc @@ -5,11 +5,30 @@ * Does rule type stuff, */ +/** + * Implements hook_rules_event_info(). + */ +function islandora_rules_event_info() { + return array( + 'islandora_object_ingested' => array( + 'group' => t('Islandora'), + 'label' => t('Object ingested'), + 'variables' => array( + 'object' => array( + 'type' => 'islandora_object', + 'label' => t('The ingested object'), + 'description' => t('A Tuque object for the ingested Fedora object, as an entity.'), + ), + ), + ), + ); +} + /** * Helper function to get reused "parameter" array. */ function islandora_rules_relationship_parameter_array() { - $to_return = array( + return array( 'subject' => array( 'type' => 'islandora_object', 'label' => t('Subject'), @@ -39,8 +58,6 @@ function islandora_rules_relationship_parameter_array() { 'default value' => 0, ), ); - - return $to_return; } /** diff --git a/islandora.rules_defaults.inc b/islandora.rules_defaults.inc new file mode 100644 index 00000000..17f83b63 --- /dev/null +++ b/islandora.rules_defaults.inc @@ -0,0 +1,26 @@ +label = 'E-mail admin'; + $rule->active = FALSE; + $rule + ->event('islandora_object_ingested') + ->action( + 'mail', + array( + 'to' => '[site:mail]', + 'subject' => '[[site:name]] "[object:label]" has been ingested', + 'message' => '[object:label] has been ingested as [object:id].', + ) + ); + return array('islandora_object_ingested_notify_admin' => $rule); +} From 4507d5b39c63b9fec103505c8cde52551c2251bf Mon Sep 17 00:00:00 2001 From: Jordan Dukart Date: Wed, 2 Apr 2014 19:50:39 +0000 Subject: [PATCH 13/45] Use redirect set in form state before defaulting to the object. --- includes/ingest.form.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/ingest.form.inc b/includes/ingest.form.inc index 89376f7d..8fd1c6ea 100644 --- a/includes/ingest.form.inc +++ b/includes/ingest.form.inc @@ -769,7 +769,7 @@ function islandora_ingest_form_submit(array $form, array &$form_state) { islandora_ingest_form_execute_consecutive_callback_steps($form, $form_state, $step); } // Ingest the objects. - $set_redirect = TRUE; + $set_redirect = isset($form_state['redirect']) ? FALSE : TRUE; foreach ($form_state['islandora']['objects'] as &$object) { try { islandora_add_object($object); From bbc6cec2298ae9ecd4f812ca414d5693a95c69b7 Mon Sep 17 00:00:00 2001 From: willtp87 Date: Thu, 3 Apr 2014 11:09:25 -0300 Subject: [PATCH 14/45] date time available --- islandora.module | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/islandora.module b/islandora.module index 9e7809eb..fd71bb3c 100644 --- a/islandora.module +++ b/islandora.module @@ -1531,6 +1531,11 @@ function islandora_entity_property_info() { 'label' => t('Content Models'), 'description' => t('The list of content models which the object has.'), ); + $p['createdDate'] = array( + 'type' => 'text', + 'label' => t('Created Date'), + 'description' => t('When the object was created.'), + ); return $info; } From 785eedcc8397ff4d432570fc0d4e95429dcac64a Mon Sep 17 00:00:00 2001 From: Adam Vessey Date: Fri, 4 Apr 2014 13:42:22 +0000 Subject: [PATCH 15/45] Make the "undo_function" bit optional. The "undo_function" part of callbacks was required, even though it might not be required for functionality... Make it optional, so we don't end up making/using no-op functions to avoid doing anything. --- includes/ingest.form.inc | 12 +++++++----- islandora.api.php | 6 +++--- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/includes/ingest.form.inc b/includes/ingest.form.inc index 8fd1c6ea..f7979063 100644 --- a/includes/ingest.form.inc +++ b/includes/ingest.form.inc @@ -467,12 +467,14 @@ function islandora_ingest_form_undo_consecutive_callback_steps(array $form, arra * The step which the undo callback is being called on. */ function islandora_ingest_form_undo_callback_step(array $form, array &$form_state, array $step) { - $args = array(&$form_state); - $args = isset($step['undo_function']['args']) ? array_merge($args, $step['undo_function']['args']) : $args; - if (isset($step['undo_function']['file'])) { - require_once drupal_get_path('module', $step['module']) . "/" . $step['undo_function']['file']; + if (isset($step['undo_function'])) { + $args = array(&$form_state); + $args = isset($step['undo_function']['args']) ? array_merge($args, $step['undo_function']['args']) : $args; + if (isset($step['undo_function']['file'])) { + require_once drupal_get_path('module', $step['module']) . "/" . $step['undo_function']['file']; + } + call_user_func_array($step['undo_function']['function'], $args); } - call_user_func_array($step['undo_function']['function'], $args); } /** diff --git a/islandora.api.php b/islandora.api.php index e8b45ba7..d32b7fdf 100644 --- a/islandora.api.php +++ b/islandora.api.php @@ -423,13 +423,13 @@ function hook_islandora_undeletable_datastreams(array $models) { * - form_id: The form building function to call to get the form structure * for this step. * - args: An array of arguments to pass to the form building function. - * Required "callback" type specific parameters: - * - do_function: An associate array including: + * "Callback" type specific parameters: + * - do_function: A required associative array including: * - 'function': The callback function to be called. * - 'args': An array of arguments to pass to the callback function. * - 'file': A file to include (relative to the module's path, including * the file's extension). - * - undo_function: An associate array including: + * - undo_function: An optional associative array including: * - 'function': The callback function to be called to reverse the * executed action in the ingest steps. * - 'args': An array of arguments to pass to the callback function. From e9faa1810d4f2b9631c112c91ac3a818e5fa5c30 Mon Sep 17 00:00:00 2001 From: Adam Vessey Date: Fri, 4 Apr 2014 16:02:19 +0000 Subject: [PATCH 16/45] Try getting rid of the "upgrade-all" shenanigans. --- tests/scripts/travis_setup.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/scripts/travis_setup.sh b/tests/scripts/travis_setup.sh index c1bd7751..4079d3b6 100755 --- a/tests/scripts/travis_setup.sh +++ b/tests/scripts/travis_setup.sh @@ -14,7 +14,6 @@ export JAVA_OPTS="-Xms1024m -Xmx1024m -XX:MaxPermSize=512m -XX:+CMSClassUnloadin cd $HOME pear upgrade --force Console_Getopt pear upgrade --force pear -pear upgrade-all pear channel-discover pear.drush.org pear channel-discover pear.drush.org pear channel-discover pear.phpqatools.org From 254ee5d60be9b3e169d4483778b350f9c23ed3c8 Mon Sep 17 00:00:00 2001 From: willtp87 Date: Tue, 8 Apr 2014 13:32:59 -0300 Subject: [PATCH 17/45] passing derivative deffinition to callback (usefull for single callback handling many derivatives) --- includes/derivatives.inc | 16 ++++++++++------ islandora.api.php | 2 +- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/includes/derivatives.inc b/includes/derivatives.inc index d25789cc..2f4adc51 100644 --- a/includes/derivatives.inc +++ b/includes/derivatives.inc @@ -49,7 +49,7 @@ function islandora_do_derivatives(AbstractObject $object, array $options) { } foreach ($hook['function'] as $function) { if (function_exists($function)) { - $logging = call_user_func($function, $object, $options['force']); + $logging = call_user_func($function, $object, $options['force'], $hook); if (!empty($logging)) { $results[] = $logging; } @@ -142,11 +142,15 @@ function islandora_do_batch_derivatives(AbstractObject $object, array $options) $file = $hook['file']; } foreach ($hook['function'] as $function) { - $operations[] = array('islandora_derivative_perform_batch_operation', array( - $function, - $file, - $object->id, - $options['force']), + $operations[] = array( + 'islandora_derivative_perform_batch_operation', + array( + $function, + $file, + $object->id, + $options['force'], + $hook + ), ); } } diff --git a/islandora.api.php b/islandora.api.php index d32b7fdf..eeeeae1c 100644 --- a/islandora.api.php +++ b/islandora.api.php @@ -635,7 +635,7 @@ function hook_CMODEL_PID_islandora_overview_object_alter(AbstractObject &$object * - function: An array of function(s) to be ran when constructing * derivatives. Functions that are defined to be called for derivation * creation must have the following structure: - * module_name_derivative_creation_function($object, $force = FALSE) + * module_name_derivative_creation_function($object, $force = FALSE, $hook) * These functions must return an array in the structure of: * - success: Bool denoting whether the operation was successful. * - messages: An array structure containing zero or more array's with the From 7be2653ba646af812fdfaa7c3ef7996265c4d208 Mon Sep 17 00:00:00 2001 From: willtp87 Date: Tue, 8 Apr 2014 13:47:51 -0300 Subject: [PATCH 18/45] forgot comma --- includes/derivatives.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/derivatives.inc b/includes/derivatives.inc index 2f4adc51..635c1c54 100644 --- a/includes/derivatives.inc +++ b/includes/derivatives.inc @@ -149,7 +149,7 @@ function islandora_do_batch_derivatives(AbstractObject $object, array $options) $file, $object->id, $options['force'], - $hook + $hook, ), ); } From 91c7103f50922fc4d20e70ff1250d3eae5b4b232 Mon Sep 17 00:00:00 2001 From: Jordan Dukart Date: Wed, 9 Apr 2014 16:13:19 +0000 Subject: [PATCH 19/45] Don't render unneeded markup when there is no thumbnail. --- theme/islandora-object.tpl.php | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/theme/islandora-object.tpl.php b/theme/islandora-object.tpl.php index fdd09607..f91c3272 100644 --- a/theme/islandora-object.tpl.php +++ b/theme/islandora-object.tpl.php @@ -61,13 +61,13 @@

-
-
- -
- -
-
+ +
+
+ +
+
+
From 4a7bd945c6c191867b8c3d58545c309f313a4305 Mon Sep 17 00:00:00 2001 From: Jordan Dukart Date: Thu, 10 Apr 2014 13:19:13 +0000 Subject: [PATCH 20/45] Grab latest PHPCS as Coder now supports it. --- tests/scripts/travis_setup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/scripts/travis_setup.sh b/tests/scripts/travis_setup.sh index 4079d3b6..4e9a3563 100755 --- a/tests/scripts/travis_setup.sh +++ b/tests/scripts/travis_setup.sh @@ -18,7 +18,7 @@ pear channel-discover pear.drush.org pear channel-discover pear.drush.org pear channel-discover pear.phpqatools.org pear channel-discover pear.netpirates.net -pear install pear/PHP_CodeSniffer-1.4.8 +pear install pear/PHP_CodeSniffer pear install pear.phpunit.de/phpcpd # Install Drush From fef21063b2f447cfff8c4853347a6244cb2761e6 Mon Sep 17 00:00:00 2001 From: Alan Stanley Date: Fri, 11 Apr 2014 10:24:17 -0300 Subject: [PATCH 21/45] added new submenu paths --- islandora.module | 46 ++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 44 insertions(+), 2 deletions(-) diff --git a/islandora.module b/islandora.module index fd71bb3c..37d559ef 100644 --- a/islandora.module +++ b/islandora.module @@ -109,13 +109,35 @@ function islandora_menu() { 'file' => 'includes/metadata.inc', 'access arguments' => array('administer site configuration'), ); - $items['admin/islandora/solution_packs'] = array( - 'title' => 'Solution packs', + $items['admin/islandora/solution_pack_config'] = array( + 'title' => 'Solution pack configuration', + 'description' => 'Configure Islandora solution packs.', + 'access callback' => 'islandora_find_package', + 'access arguments' => array('Islandora Solution Packs'), + 'type' => MENU_NORMAL_ITEM, + ); + $items['admin/islandora/islandora_viewers'] = array( + 'title' => 'Islandora Viewers', + 'description' => 'Configure custom viewers.', + 'access callback' => 'islandora_find_package', + 'access arguments' => array('Islandora Viewers'), + 'type' => MENU_NORMAL_ITEM, + ); + $items['admin/islandora/islandora_utilities'] = array( + 'title' => 'Islandora Utility Modules', + 'description' => 'Configure Islandora utility modules.', + 'access callback' => 'islandora_find_package', + 'access arguments' => array('Islandora Utilities'), + 'type' => MENU_NORMAL_ITEM, + ); + $items['admin/islandora/solution_pack_config/solution_packs'] = array( + 'title' => 'Solution packs required objects', 'description' => 'Install content models and collections required by installed solution packs.', 'page callback' => 'islandora_solution_packs_admin', 'access arguments' => array(ISLANDORA_ADD_DS), 'file' => 'includes/solution_packs.inc', 'type' => MENU_NORMAL_ITEM, + 'weight' => -1, ); $items['islandora'] = array( 'title' => 'Islandora Repository', @@ -1869,3 +1891,23 @@ function islandora_islandora_datastream_access($op, AbstractDatastream $datastre } return $result; } + + /** + * Access for submenu items. + * + * @param string $package_name + * Name of the package + * + * @return bool + */ +function islandora_find_package($package_name) { + $results = system_get_info('module'); + $found = FALSE; + foreach ($results as $name => $values) { + if ($values['package'] == $package_name) { + $found = TRUE; + break; + } + } + return $found && user_access('administer site configuration'); +} \ No newline at end of file From f3a4ea9ae4ca6bad707ae79da655970131f5c30f Mon Sep 17 00:00:00 2001 From: Alan Stanley Date: Fri, 11 Apr 2014 11:25:19 -0300 Subject: [PATCH 22/45] coder --- islandora.module | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/islandora.module b/islandora.module index 37d559ef..f979a4e5 100644 --- a/islandora.module +++ b/islandora.module @@ -109,7 +109,7 @@ function islandora_menu() { 'file' => 'includes/metadata.inc', 'access arguments' => array('administer site configuration'), ); - $items['admin/islandora/solution_pack_config'] = array( + $items['admin/islandora/solution_pack_config'] = array( 'title' => 'Solution pack configuration', 'description' => 'Configure Islandora solution packs.', 'access callback' => 'islandora_find_package', @@ -1852,9 +1852,9 @@ function islandora_repair_drupal_filter() { } } - /** - * Implements hook_islandora_metadata_display_info(). - */ +/** + * Implements hook_islandora_metadata_display_info(). + */ function islandora_islandora_metadata_display_info() { return array( 'dublin_core' => array( @@ -1892,13 +1892,14 @@ function islandora_islandora_datastream_access($op, AbstractDatastream $datastre return $result; } - /** +/** * Access for submenu items. * * @param string $package_name * Name of the package * * @return bool + * Access granted */ function islandora_find_package($package_name) { $results = system_get_info('module'); @@ -1910,4 +1911,4 @@ function islandora_find_package($package_name) { } } return $found && user_access('administer site configuration'); -} \ No newline at end of file +} From 73c755ff85fcfb511ae6e9527dd474ba0d5fced4 Mon Sep 17 00:00:00 2001 From: Alan Stanley Date: Fri, 11 Apr 2014 15:41:50 -0300 Subject: [PATCH 23/45] Changed submenu name --- islandora.module | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/islandora.module b/islandora.module index f979a4e5..cc4cee4b 100644 --- a/islandora.module +++ b/islandora.module @@ -123,11 +123,11 @@ function islandora_menu() { 'access arguments' => array('Islandora Viewers'), 'type' => MENU_NORMAL_ITEM, ); - $items['admin/islandora/islandora_utilities'] = array( + $items['admin/islandora/tools'] = array( 'title' => 'Islandora Utility Modules', 'description' => 'Configure Islandora utility modules.', 'access callback' => 'islandora_find_package', - 'access arguments' => array('Islandora Utilities'), + 'access arguments' => array('Islandora Tools'), 'type' => MENU_NORMAL_ITEM, ); $items['admin/islandora/solution_pack_config/solution_packs'] = array( From 325e3699b6fde5036fdd6e0c040b5a315e678a4c Mon Sep 17 00:00:00 2001 From: willtp87 Date: Tue, 15 Apr 2014 12:41:30 -0300 Subject: [PATCH 24/45] passing hook info through to batch derivative creation correctly --- includes/regenerate_derivatives.form.inc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/includes/regenerate_derivatives.form.inc b/includes/regenerate_derivatives.form.inc index 7fd8d059..9a7a097e 100644 --- a/includes/regenerate_derivatives.form.inc +++ b/includes/regenerate_derivatives.form.inc @@ -142,15 +142,17 @@ function islandora_regenerate_datastream_derivative_batch(AbstractDatastream $da * The pid of the object we are performing. * @param bool $force * Whether we are forcing derivative regeneration or not. + * @param array $hook + * The derivative definition. * @param array $context * The context of the current batch operation. */ -function islandora_derivative_perform_batch_operation($function, $file, $pid, $force, &$context) { +function islandora_derivative_perform_batch_operation($function, $file, $pid, $force, $hook, &$context) { if ($file) { require_once $file; } if (function_exists($function)) { - $logging = call_user_func($function, islandora_object_load($pid), $force); + $logging = call_user_func($function, islandora_object_load($pid), $force, $hook); if (!empty($logging)) { $context['results']['logging'][] = $logging; } From cc726ed4cd63dc62f9e4fd69884e5535f258a3e1 Mon Sep 17 00:00:00 2001 From: qadan Date: Tue, 15 Apr 2014 18:32:51 +0000 Subject: [PATCH 25/45] minor improvements to ingestConstructedObject() --- tests/islandora_web_test_case.inc | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/tests/islandora_web_test_case.inc b/tests/islandora_web_test_case.inc index 89ca9cbb..d5830e70 100644 --- a/tests/islandora_web_test_case.inc +++ b/tests/islandora_web_test_case.inc @@ -315,7 +315,8 @@ class IslandoraWebTestCase extends DrupalWebTestCase { * An array containing object information using these keys: * 'label' - The object label; randomized if not set. * 'pid' - 'namespace:pid', or just 'namespace' to generate the suffix. - * 'models' - An array that can contain multiple content model PIDs. + * 'models' - An array that can contain multiple content model PIDs, or a + * string containing a single content model PID. * 'owner' - The object's owner. Defaults to the currently logged-in user, * if available. It is recommended to set this to a value that can be found * in $this->users; otherwise, this object will have to be manually deleted. @@ -331,8 +332,7 @@ class IslandoraWebTestCase extends DrupalWebTestCase { * FALSE if the object ingest failed, or the object array if successful. */ public function ingestConstructedObject(array $properties = array(), array $datastreams = array()) { - module_load_include('inc', 'islandora', 'includes/tuque'); - $tuque = new IslandoraTuque(); + $tuque = islandora_get_tuque_connection($this->admin); $repository = $tuque->repository; if (!isset($properties['pid'])) { $properties['pid'] = "islandora"; @@ -355,13 +355,14 @@ class IslandoraWebTestCase extends DrupalWebTestCase { $object->owner = $this->loggedInUser->name; } - if (isset($properties['models']) && is_array($properties['models'])) { - foreach ($properties['models'] as $model) { - $object->relationships->add(FEDORA_MODEL_URI, 'hasModel', $model); + if (isset($properties['models'])) { + try { + $object->models = (array) $properties['models']; + } + catch (Exception $e) { + $this->fail("Encountered an exception when trying to add content models to {$object->id}: $e"); + return FALSE; } - } - elseif (isset($properties['models']) && !is_array($properties['models'])) { - $this->fail(t("'models' key of properties variable is not an array. Content model(s) will not be set."), 'Islandora'); } $repository->ingestObject($object); From 669e28128ecc9fe6e6089b95e6b9778b7b7466c4 Mon Sep 17 00:00:00 2001 From: Alan Stanley Date: Wed, 16 Apr 2014 08:39:54 -0300 Subject: [PATCH 26/45] fixed path --- includes/solution_packs.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/solution_packs.inc b/includes/solution_packs.inc index e07e76e7..27af2bfd 100644 --- a/includes/solution_packs.inc +++ b/includes/solution_packs.inc @@ -256,7 +256,7 @@ function islandora_solution_pack_form_submit(array $form, array &$form_state) { * the batch. * @param array $not_checked * The object that will bot be install. - * + * * @return array * An array defining a batch which can be passed on to batch_set(). */ @@ -367,7 +367,7 @@ function islandora_install_solution_pack($module, $op = 'install', $force = FALS $t = get_t(); // Some general replacements. - $admin_link = l($t('Solution Pack admin'), 'admin/islandora/solution_packs'); + $admin_link = l($t('Solution Pack admin'), 'admin/solution_pack_config/islandora/solution_packs'); $config_link = l($t('Islandora configuration'), 'admin/islandora/configure'); $t_params = array( '@module' => $module, From 95cd45660702164b0e2b12433c933b86956c246e Mon Sep 17 00:00:00 2001 From: qadan Date: Wed, 16 Apr 2014 16:20:40 +0000 Subject: [PATCH 27/45] some functionality i would like also yesplz --- tests/islandora_web_test_case.inc | 78 +++++++++++++++++++++++++++++++ 1 file changed, 78 insertions(+) diff --git a/tests/islandora_web_test_case.inc b/tests/islandora_web_test_case.inc index d5830e70..ad670d54 100644 --- a/tests/islandora_web_test_case.inc +++ b/tests/islandora_web_test_case.inc @@ -443,4 +443,82 @@ QUERY; } } + /** + * These are a few quick helper functions to fill in a gap in the standard + * DrupalWebTestCase where no function exists to test for the simple existence + * or non-existence of an error. + */ + + /** + * Asserts that an error is found in $this->content. + * + * @param string $message + * The message to pass on to the results. + * @param string $group + * The group to place the result in. + * + * @return bool + * TRUE on success, FALSE on failure. + */ + public function assertError($message = '', $group = 'Other') { + if (!$message) { + $message = "Error found on current page when error was expected."; + } + return $this->assertRaw("
", $message, $group); + } + + /** + * Asserts that no error is found in $this->content. + * + * @param string $message + * The message to pass on to the results. + * @param string $group + * The group to place the result in. + * + * @return bool + * TRUE on success, FALSE on failure. + */ + public function assertNoError($message = '', $group = 'Other') { + if (!$message) { + $message = "No error found on current page when no error was expected."; + } + return $this->assertNoRaw("
", $message, $group); + } + + /** + * Asserts that a warning is found in $this->content. + * + * @param string $message + * The message to pass on to the results. + * @param string $group + * The group to place the result in. + * + * @return bool + * TRUE on success, FALSE on failure. + */ + public function assertWarning($message = '', $group = 'Other') { + if (!$message) { + $message = "Warning found on current page when warning was expected."; + } + return $this->assertRaw("
", $message, $group); + } + + /** + * Asserts that no warning is found in $this->content. + * + * @param string $message + * The message to pass on to the results. + * @param string $group + * The group to place the result in. + * + * @return bool + * TRUE on success, FALSE on failure. + */ + public function assertNoWarning($message = '', $group = 'Other') { + if (!$message) { + $message = "No warning found on current page when no warning was expected."; + } + return $this->assertNoRaw("
", $message, $group); + } + } From 75a6a4c0f54472795ce351ddf0969cbbfc7cabf9 Mon Sep 17 00:00:00 2001 From: Alan Stanley Date: Thu, 17 Apr 2014 16:41:25 -0300 Subject: [PATCH 28/45] fixed path --- includes/solution_packs.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/solution_packs.inc b/includes/solution_packs.inc index 27af2bfd..7c0d9aad 100644 --- a/includes/solution_packs.inc +++ b/includes/solution_packs.inc @@ -367,7 +367,7 @@ function islandora_install_solution_pack($module, $op = 'install', $force = FALS $t = get_t(); // Some general replacements. - $admin_link = l($t('Solution Pack admin'), 'admin/solution_pack_config/islandora/solution_packs'); + $admin_link = l($t('Solution Pack admin'), 'admin/islandora/solution_pack_config/solution_packs'); $config_link = l($t('Islandora configuration'), 'admin/islandora/configure'); $t_params = array( '@module' => $module, From edd46656e9d129efcc2868777dd0a4406a1caeac Mon Sep 17 00:00:00 2001 From: Alan Stanley Date: Thu, 17 Apr 2014 16:45:52 -0300 Subject: [PATCH 29/45] fixed path --- includes/solution_packs.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/solution_packs.inc b/includes/solution_packs.inc index 7c0d9aad..1399bd9e 100644 --- a/includes/solution_packs.inc +++ b/includes/solution_packs.inc @@ -367,7 +367,7 @@ function islandora_install_solution_pack($module, $op = 'install', $force = FALS $t = get_t(); // Some general replacements. - $admin_link = l($t('Solution Pack admin'), 'admin/islandora/solution_pack_config/solution_packs'); + $admin_link = l($t('Solution Pack admin'), 'admin/islandora/solution_pack_config'); $config_link = l($t('Islandora configuration'), 'admin/islandora/configure'); $t_params = array( '@module' => $module, From f5786f77298c4cf51f77d7a16ca4c652fbe8fcc4 Mon Sep 17 00:00:00 2001 From: Jordan Dukart Date: Mon, 21 Apr 2014 10:53:43 +0000 Subject: [PATCH 30/45] Use drupal_random_bytes just to be careful. --- includes/authtokens.inc | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/includes/authtokens.inc b/includes/authtokens.inc index 36e8689f..d5d98117 100644 --- a/includes/authtokens.inc +++ b/includes/authtokens.inc @@ -36,12 +36,7 @@ define('ISLANDORA_AUTHTOKEN_TOKEN_TIMEOUT', 300); function islandora_get_object_token($pid, $dsid, $uses = 1) { global $user; $time = time(); - // The function mt_rand is not considered cryptographically secure - // and openssl_rando_pseudo_bytes() is only available in PHP > 5.3. - // We might be safe in this case because mt_rand should never be using - // the same seed, but this is still more secure. - $token = hash("sha256", mt_rand() . $time); - + $token = bin2hex(drupal_random_bytes(32)); $id = db_insert("islandora_authtokens")->fields( array( 'token' => $token, From caf711aa3f066bfeef49c0e54e31ca054cb56b2a Mon Sep 17 00:00:00 2001 From: qadan Date: Mon, 21 Apr 2014 19:57:14 +0000 Subject: [PATCH 31/45] more needed functionality --- tests/islandora_web_test_case.inc | 50 +++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) diff --git a/tests/islandora_web_test_case.inc b/tests/islandora_web_test_case.inc index ad670d54..51d188cb 100644 --- a/tests/islandora_web_test_case.inc +++ b/tests/islandora_web_test_case.inc @@ -521,4 +521,54 @@ QUERY; return $this->assertNoRaw("
", $message, $group); } + /** + * Makes a drupalPost() request, using the form submit button's ID. + * + * Because drupalPost() is silly and doesn't let us choose which button we'd + * like to select if multiple buttons have the same value, this function + * allows us to select whatever button we'd like based on the ID instead. + * + * This is done via the absolutely hilarious method of fudging the actual + * button labels that don't have the ID we want, so that the only one left + * with the correct label is the one with the right ID. + * + * @see DrupalWebTestCase::drupalPost(). + * + * @param $path + * Location of the post form. + * @param $edit + * Field data in an associative array. + * @param $submit + * Value of the submit button whose click is to be emulated. + * @param $id + * ID of the submit button whose click is to be emulated. + * @param array $options + * Options to be forwarded to url(). + * @param array $headers + * An array containing additional HTTP request headers, each formatted as + * "name: value". + * @param null $form_html_id + * (optional) HTML ID of the form to be submitted. + * @param null $extra_post + * (optional) A string of additional data to append to the POST submission. + * + * @return bool|string + * The content from the POST request's curlExec, or FALSE on fail. + */ + public function drupalPostByID($path, $edit, $submit, $id, array $options = array(), array $headers = array(), $form_html_id = NULL, $extra_post = NULL) { + $buttons = $this->xpath("//input[@type=\"submit\" and @value=\"{$submit}\"]"); + if (empty($buttons)) { + $this->fail("No buttons found on the page with value '$submit'"); + return FALSE; + } + $i = 0; + foreach ($buttons as $button) { + if ($button['id'] !== $id) { + $button['value'] .= "_$i"; + $i++; + } + } + return $this->drupalPost($path, $edit, $submit, $options, $headers, $form_html_id, $extra_post); + } + } From 230e4bd2b4d36875e0198eea3b09951f8d6ce4d5 Mon Sep 17 00:00:00 2001 From: qadan Date: Mon, 21 Apr 2014 18:03:54 -0300 Subject: [PATCH 32/45] Coder fixes --- tests/islandora_web_test_case.inc | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/islandora_web_test_case.inc b/tests/islandora_web_test_case.inc index 51d188cb..329ff53e 100644 --- a/tests/islandora_web_test_case.inc +++ b/tests/islandora_web_test_case.inc @@ -532,15 +532,15 @@ QUERY; * button labels that don't have the ID we want, so that the only one left * with the correct label is the one with the right ID. * - * @see DrupalWebTestCase::drupalPost(). + * @see DrupalWebTestCase::drupalPost() * - * @param $path + * @param string $path * Location of the post form. - * @param $edit + * @param array $edit * Field data in an associative array. - * @param $submit + * @param string $submit * Value of the submit button whose click is to be emulated. - * @param $id + * @param string $id * ID of the submit button whose click is to be emulated. * @param array $options * Options to be forwarded to url(). From 7b0f9595ee4898889303b6ca1e48a092bbad8b30 Mon Sep 17 00:00:00 2001 From: Adam Vessey Date: Tue, 22 Apr 2014 12:50:22 +0000 Subject: [PATCH 33/45] Try some composer stuff. --- tests/scripts/travis_setup.sh | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tests/scripts/travis_setup.sh b/tests/scripts/travis_setup.sh index 4e9a3563..fe012dd1 100755 --- a/tests/scripts/travis_setup.sh +++ b/tests/scripts/travis_setup.sh @@ -12,14 +12,12 @@ export CATALINA_HOME='.' export JAVA_OPTS="-Xms1024m -Xmx1024m -XX:MaxPermSize=512m -XX:+CMSClassUnloadingEnabled -Djavax.net.ssl.trustStore=$CATALINA_HOME/fedora/server/truststore -Djavax.net.ssl.trustStorePassword=tomcat" ./bin/startup.sh cd $HOME +pear channel-discover pear.drush.org pear upgrade --force Console_Getopt pear upgrade --force pear pear channel-discover pear.drush.org -pear channel-discover pear.drush.org -pear channel-discover pear.phpqatools.org -pear channel-discover pear.netpirates.net -pear install pear/PHP_CodeSniffer -pear install pear.phpunit.de/phpcpd + +composer global require squizlabs/php_codesniffer sebastian/phpcpd # Install Drush git clone https://github.com/drush-ops/drush.git From afeac089e404f8144b631e0a3928907eb91daf7d Mon Sep 17 00:00:00 2001 From: Adam Vessey Date: Tue, 22 Apr 2014 12:55:51 +0000 Subject: [PATCH 34/45] The second... --- tests/scripts/travis_setup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/scripts/travis_setup.sh b/tests/scripts/travis_setup.sh index fe012dd1..ee6200d5 100755 --- a/tests/scripts/travis_setup.sh +++ b/tests/scripts/travis_setup.sh @@ -17,7 +17,7 @@ pear upgrade --force Console_Getopt pear upgrade --force pear pear channel-discover pear.drush.org -composer global require squizlabs/php_codesniffer sebastian/phpcpd +composer global require 'squizlabs/php_codesniffer=*' 'sebastian/phpcpd=*' # Install Drush git clone https://github.com/drush-ops/drush.git From 199f1699004aa8969bdf4e20a6073599ed63151b Mon Sep 17 00:00:00 2001 From: Adam Vessey Date: Tue, 22 Apr 2014 13:01:28 +0000 Subject: [PATCH 35/45] Add "prefer-source" dealio. --- tests/scripts/travis_setup.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/scripts/travis_setup.sh b/tests/scripts/travis_setup.sh index ee6200d5..ada5c4c6 100755 --- a/tests/scripts/travis_setup.sh +++ b/tests/scripts/travis_setup.sh @@ -17,7 +17,8 @@ pear upgrade --force Console_Getopt pear upgrade --force pear pear channel-discover pear.drush.org -composer global require 'squizlabs/php_codesniffer=*' 'sebastian/phpcpd=*' +# "prefer-source" required due to SSL shenanigans on the Travis boxes... +composer global require --prefer-source 'squizlabs/php_codesniffer=*' 'sebastian/phpcpd=*' # Install Drush git clone https://github.com/drush-ops/drush.git From 6c6c66e5ad0a1216e3b30963d97e9450e9aefdf2 Mon Sep 17 00:00:00 2001 From: Adam Vessey Date: Tue, 22 Apr 2014 13:37:37 +0000 Subject: [PATCH 36/45] Throw stuff onto the PATH, 'cause Travis is silly. Really, how we're using it, I guess... Shrug. --- tests/scripts/travis_setup.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/scripts/travis_setup.sh b/tests/scripts/travis_setup.sh index ada5c4c6..264085d1 100755 --- a/tests/scripts/travis_setup.sh +++ b/tests/scripts/travis_setup.sh @@ -19,6 +19,9 @@ pear channel-discover pear.drush.org # "prefer-source" required due to SSL shenanigans on the Travis boxes... composer global require --prefer-source 'squizlabs/php_codesniffer=*' 'sebastian/phpcpd=*' +# Because we can't add to the PATH here and this file is used in many repos, +# let's just throw symlinks in. +find $HOME/.composer/vendor/bin -executable \! -type d -exec sudo ln -s {} /usr/local/sbin/ \; # Install Drush git clone https://github.com/drush-ops/drush.git From 34cd387bcaca859e899f75b172e0bffc96b7967a Mon Sep 17 00:00:00 2001 From: Adam Vessey Date: Tue, 22 Apr 2014 14:26:19 +0000 Subject: [PATCH 37/45] Try to expose Composer's autoloading. --- tests/scripts/travis_setup.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/scripts/travis_setup.sh b/tests/scripts/travis_setup.sh index 264085d1..c619b2e9 100755 --- a/tests/scripts/travis_setup.sh +++ b/tests/scripts/travis_setup.sh @@ -35,6 +35,8 @@ phpenv rehash drush dl --yes drupal cd drupal-* drush si minimal --db-url=mysql://drupal:drupal@localhost/drupal --yes +# Needs to make things from Composer be available (PHP CS, primarily) +echo "include_once $HOME/.composer/vendor/autoload.php;" >> sites/default/settings.php drush runserver --php-cgi=$HOME/.phpenv/shims/php-cgi localhost:8081 &>/dev/null & ln -s $ISLANDORA_DIR sites/all/modules/islandora mv sites/all/modules/islandora/tests/travis.test_config.ini sites/all/modules/islandora/tests/test_config.ini From e8390a99eec7fd6e6ef5cab5a7deb993746729ca Mon Sep 17 00:00:00 2001 From: Adam Vessey Date: Tue, 22 Apr 2014 14:32:42 +0000 Subject: [PATCH 38/45] Ensure we can write to the settings.php --- tests/scripts/travis_setup.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/scripts/travis_setup.sh b/tests/scripts/travis_setup.sh index c619b2e9..7359fe0d 100755 --- a/tests/scripts/travis_setup.sh +++ b/tests/scripts/travis_setup.sh @@ -36,7 +36,9 @@ drush dl --yes drupal cd drupal-* drush si minimal --db-url=mysql://drupal:drupal@localhost/drupal --yes # Needs to make things from Composer be available (PHP CS, primarily) +sudo chmod a+w sites/default/settings.php echo "include_once $HOME/.composer/vendor/autoload.php;" >> sites/default/settings.php +sudo chmod a-w sites/default/settings.php drush runserver --php-cgi=$HOME/.phpenv/shims/php-cgi localhost:8081 &>/dev/null & ln -s $ISLANDORA_DIR sites/all/modules/islandora mv sites/all/modules/islandora/tests/travis.test_config.ini sites/all/modules/islandora/tests/test_config.ini From cb22924a53af3c705a17656e437d589f757c331a Mon Sep 17 00:00:00 2001 From: Adam Vessey Date: Tue, 22 Apr 2014 14:39:46 +0000 Subject: [PATCH 39/45] Add missing quotes, 'cause derp. --- tests/scripts/travis_setup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/scripts/travis_setup.sh b/tests/scripts/travis_setup.sh index 7359fe0d..3991afcd 100755 --- a/tests/scripts/travis_setup.sh +++ b/tests/scripts/travis_setup.sh @@ -37,7 +37,7 @@ cd drupal-* drush si minimal --db-url=mysql://drupal:drupal@localhost/drupal --yes # Needs to make things from Composer be available (PHP CS, primarily) sudo chmod a+w sites/default/settings.php -echo "include_once $HOME/.composer/vendor/autoload.php;" >> sites/default/settings.php +echo "include_once '$HOME/.composer/vendor/autoload.php';" >> sites/default/settings.php sudo chmod a-w sites/default/settings.php drush runserver --php-cgi=$HOME/.phpenv/shims/php-cgi localhost:8081 &>/dev/null & ln -s $ISLANDORA_DIR sites/all/modules/islandora From a3d1230e0cdd5bc97b527dbd209cd1bf68262a2f Mon Sep 17 00:00:00 2001 From: qadan Date: Tue, 22 Apr 2014 16:39:08 -0300 Subject: [PATCH 40/45] travis after_failure script --- .travis.yml | 6 ++++++ tests/scripts/travis_after_failure.sh | 19 +++++++++++++++++++ 2 files changed, 25 insertions(+) create mode 100644 tests/scripts/travis_after_failure.sh diff --git a/.travis.yml b/.travis.yml index 660fb448..2653fc16 100644 --- a/.travis.yml +++ b/.travis.yml @@ -9,6 +9,10 @@ env: - FEDORA_VERSION="3.5" - FEDORA_VERSION="3.6.2" - FEDORA_VERSION="3.7.0" + global: + # This key is unique to the Islandora/islandora repository; logging will + # fail on forked repositories unless a new unique key is generated for them. + - secure: "nTv2Zb/qKlECK+xE5ahbfXI9ZZbf2ZMd796q7oPlTxUwvu6nomHnUOjJATl6tq2cj23PyJ89Jlgl5cMZ5h0QMUzYpN5hPyY6oCJxWgFamFaE3bv5E/rBd1f6WVTJW7S4UKn8Mr9R2PrX+ZxQZGVIigAfR8VfhQuP8PcuO5eMLBk=" before_install: - export ISLANDORA_DIR=$TRAVIS_BUILD_DIR - $TRAVIS_BUILD_DIR/tests/scripts/travis_setup.sh @@ -19,3 +23,5 @@ script: - drush coder-review --reviews=production,security,style,i18n,potx,sniffer islandora - phpcpd --names *.module,*.inc,*.test sites/all/modules/islandora - drush test-run --uri=http://localhost:8081 Islandora +after_failure: + - $TRAVIS_BUILD_DIR/tests/scripts/travis_after_install.sh diff --git a/tests/scripts/travis_after_failure.sh b/tests/scripts/travis_after_failure.sh new file mode 100644 index 00000000..288cb75c --- /dev/null +++ b/tests/scripts/travis_after_failure.sh @@ -0,0 +1,19 @@ +#!/bin/bash + +# Get the end portion of the TRAVIS_REPO_SLUG for the branch name. +DELIMITED_SLUG = $(echo $TRAVIS_REPO_SLUG | tr "/" "\n") +CURRENT_REPO = "${DELIMITED_SLUG[1]}" + +# Git business +export VERBOSE_DIR = $HOME/sites/default/files/simpletest/verbose +cd $HOME +git clone https://islandora-logger:$LOGGER_PW@github.com/Islandora/islandora_travis_logs.git +cd islandora_travis_logs +git checkout -B $CURRENT_REPO + +# Out with the old, in with the new +git rm $HOME/islandora_travis_logs/*.* +cp $VERBOSE_DIR/*.* $HOME/islandora_travis_logs +git add -A +git commit -m "Job: $TRAVIS_JOB_NUMBER Commit: $TRAVIS_COMMIT" +git push origin $CURRENT_REPO From 0f551f87dae0f789117a0ac84f060d34793d3de5 Mon Sep 17 00:00:00 2001 From: qadan Date: Wed, 23 Apr 2014 11:35:30 -0300 Subject: [PATCH 41/45] yml whoops --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index 2653fc16..94c3dfbf 100644 --- a/.travis.yml +++ b/.travis.yml @@ -6,6 +6,7 @@ branches: only: - /^7.x/ env: + matrix: - FEDORA_VERSION="3.5" - FEDORA_VERSION="3.6.2" - FEDORA_VERSION="3.7.0" From a60a35e316e889261a81e98f0f1bd63cdf4a3943 Mon Sep 17 00:00:00 2001 From: qadan Date: Wed, 23 Apr 2014 11:44:30 -0300 Subject: [PATCH 42/45] fixes to placate adam --- .travis.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index 94c3dfbf..0684252a 100644 --- a/.travis.yml +++ b/.travis.yml @@ -7,9 +7,9 @@ branches: - /^7.x/ env: matrix: - - FEDORA_VERSION="3.5" - - FEDORA_VERSION="3.6.2" - - FEDORA_VERSION="3.7.0" + - FEDORA_VERSION="3.5" + - FEDORA_VERSION="3.6.2" + - FEDORA_VERSION="3.7.0" global: # This key is unique to the Islandora/islandora repository; logging will # fail on forked repositories unless a new unique key is generated for them. @@ -25,4 +25,4 @@ script: - phpcpd --names *.module,*.inc,*.test sites/all/modules/islandora - drush test-run --uri=http://localhost:8081 Islandora after_failure: - - $TRAVIS_BUILD_DIR/tests/scripts/travis_after_install.sh + - $ISLANDORA_DIR/tests/scripts/travis_after_install.sh From 2267c4b566ca01bbb3e13fe85000da65d38942fe Mon Sep 17 00:00:00 2001 From: qadan Date: Wed, 23 Apr 2014 12:04:20 -0300 Subject: [PATCH 43/45] i am not a clever man --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 0684252a..84b226d0 100644 --- a/.travis.yml +++ b/.travis.yml @@ -25,4 +25,4 @@ script: - phpcpd --names *.module,*.inc,*.test sites/all/modules/islandora - drush test-run --uri=http://localhost:8081 Islandora after_failure: - - $ISLANDORA_DIR/tests/scripts/travis_after_install.sh + - $ISLANDORA_DIR/tests/scripts/travis_after_failure.sh From 834226c1791b17d0488e18c9118a6bfe3a281cf0 Mon Sep 17 00:00:00 2001 From: qadan Date: Wed, 23 Apr 2014 14:49:23 -0300 Subject: [PATCH 44/45] shell script permissions --- tests/scripts/travis_after_failure.sh | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100644 => 100755 tests/scripts/travis_after_failure.sh diff --git a/tests/scripts/travis_after_failure.sh b/tests/scripts/travis_after_failure.sh old mode 100644 new mode 100755 From cb8c41936e6ddb7a16a445bb653126d81aef6655 Mon Sep 17 00:00:00 2001 From: Adam Vessey Date: Wed, 23 Apr 2014 17:51:45 +0000 Subject: [PATCH 45/45] Move around some logic. "Lazy-run" validators. --- tests/datastream_validators.inc | 30 +++++++++++++++++------------- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/tests/datastream_validators.inc b/tests/datastream_validators.inc index 854f6db5..802f32d2 100644 --- a/tests/datastream_validators.inc +++ b/tests/datastream_validators.inc @@ -192,7 +192,6 @@ abstract class DatastreamValidator { $this->params = $params; if ($object[$datastream]) { $this->datastreamContent = $object[$datastream]->content; - $this->runValidators(); } else { drupal_set_message(t("Error grabbing content from datastream %datastream in object %id", 'error'), array( @@ -226,6 +225,9 @@ abstract class DatastreamValidator { * The results. */ public function getResults() { + if (empty($this->results)) { + $this->runValidators(); + } return $this->results; } @@ -415,19 +417,24 @@ class PDFDatastreamValidator extends DatastreamValidator { * integer representing the number of times it should appear in the datastream. */ class TextDatastreamValidator extends DatastreamValidator { + /** + * Constructor override; blow up if we don't have our two values. + */ + public function __construct(IslandoraFedoraObject $object, $datastream, array $params = array()) { + if (count($params) < 2) { + throw new InvalidArgumentException('$params must contain at least two values to instantiate a TextDatastreamValidator.'); + } + parent::__construct($object, $datastream, $params); + } /** * Asserts that the string given appears the correct number of times. */ protected function assertTextStringCount() { - if (!isset($this->params[1])) { - $this->addResult(FALSE, "TextDatastreamValidator cannot be instantiated without two keys in the 'params' variable."); - return; - } $string_count = self::getTextStringCount(); - $expected = $this->params[1]; + list($string, $expected) = $this->params; $assertion = $string_count === $expected; - $this->addResult($assertion, "{$this->datastream} datastream contains the word(s) '{$this->params[0]}' repeated {$string_count} time(s) (expected: {$expected})."); + $this->addResult($assertion, "{$this->datastream} datastream contains the word(s) '{$string}' repeated {$string_count} time(s) (expected: {$expected})."); } /** @@ -463,12 +470,9 @@ class WAVDatastreamValidator extends DatastreamValidator { * @param array $params * An extra array of parameters the validator might need. */ - public function __construct($object, $datastream, array $params = array()) { - $this->object = $object; - $this->datastream = $datastream; - $this->params = $params; - $this->datastreamContent = bin2hex($object[$datastream]->content); - $this->runValidators(); + public function __construct(IslandoraFedoraObject $object, $datastream, array $params = array()) { + parent::__construct($object, $datastream, $params); + $this->datastreamContent = bin2hex($this->datastreamContent); } /**