From fa5d02d89517f00a8c668241ca4e00a631fac819 Mon Sep 17 00:00:00 2001 From: Jordan Dukart Date: Thu, 5 Feb 2015 11:19:13 -0400 Subject: [PATCH 1/3] Don't double encode as drupal_set_title check_plains. --- islandora.module | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/islandora.module b/islandora.module index fba7206a..d5209c7b 100644 --- a/islandora.module +++ b/islandora.module @@ -1129,7 +1129,7 @@ function islandora_drupal_title(AbstractObject $object) { module_load_include('inc', 'islandora', 'includes/breadcrumb'); drupal_set_breadcrumb(islandora_get_breadcrumbs($object)); - return filter_xss($object->label); + return $object->label; } /** From 89036f1b66681f3591a3736ecd8aeda9c60a16da Mon Sep 17 00:00:00 2001 From: Jordan Dukart Date: Thu, 5 Feb 2015 11:27:29 -0400 Subject: [PATCH 2/3] Minus comment. --- islandora.module | 1 - 1 file changed, 1 deletion(-) diff --git a/islandora.module b/islandora.module index d5209c7b..6b3adcee 100644 --- a/islandora.module +++ b/islandora.module @@ -1117,7 +1117,6 @@ function islandora_printer_object(AbstractObject $object) { * Title callback for drupal title. * * Changes the drupal title to be the objects label. - * models that their modules want to provide a view for. * * @param AbstractObject $object * The object to view. From 8c84ccc5f2a26d515fab21bc732047d2ef6653bb Mon Sep 17 00:00:00 2001 From: Jordan Dukart Date: Thu, 5 Feb 2015 13:58:18 -0400 Subject: [PATCH 3/3] Update comment. --- islandora.module | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/islandora.module b/islandora.module index 6b3adcee..b4105019 100644 --- a/islandora.module +++ b/islandora.module @@ -1122,7 +1122,9 @@ function islandora_printer_object(AbstractObject $object) { * The object to view. * * @return string - * The objects label. + * The objects label. Note that we return the raw value to prevent + * double encoding, as we expect drupal_set_title() to check_plain() down + * the road. */ function islandora_drupal_title(AbstractObject $object) { module_load_include('inc', 'islandora', 'includes/breadcrumb');