From e1428bb13afe7ad5281880e7b9221209969438f6 Mon Sep 17 00:00:00 2001
From: Seth Shaw <seth.shaw@unlv.edu>
Date: Wed, 18 May 2022 08:43:12 -0700
Subject: [PATCH] PR recommendations; clarify max-depth config

---
 .../islandora_breadcrumbs.links.menu.yml                      | 2 +-
 .../src/Form/IslandoraBreadcrumbsSettingsForm.php             | 4 ++--
 .../islandora_breadcrumbs/src/IslandoraBreadcrumbBuilder.php  | 1 +
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/modules/islandora_breadcrumbs/islandora_breadcrumbs.links.menu.yml b/modules/islandora_breadcrumbs/islandora_breadcrumbs.links.menu.yml
index d198060b..dcf99534 100644
--- a/modules/islandora_breadcrumbs/islandora_breadcrumbs.links.menu.yml
+++ b/modules/islandora_breadcrumbs/islandora_breadcrumbs.links.menu.yml
@@ -2,4 +2,4 @@ system.islandora_breadcrumbs_settings:
   title: 'Breadcrumbs Settings'
   parent: system.admin_config_islandora
   route_name: system.islandora_breadcrumbs_settings
-  description: 'Configure Islandora breadcrumb settings'
\ No newline at end of file
+  description: 'Configure Islandora breadcrumb settings'
diff --git a/modules/islandora_breadcrumbs/src/Form/IslandoraBreadcrumbsSettingsForm.php b/modules/islandora_breadcrumbs/src/Form/IslandoraBreadcrumbsSettingsForm.php
index bdaa84ef..679a565e 100644
--- a/modules/islandora_breadcrumbs/src/Form/IslandoraBreadcrumbsSettingsForm.php
+++ b/modules/islandora_breadcrumbs/src/Form/IslandoraBreadcrumbsSettingsForm.php
@@ -45,8 +45,8 @@ class IslandoraBreadcrumbsSettingsForm extends ConfigFormBase {
       '#default_value' => $config->get('maxDepth'),
       '#min' => -1,
       '#step' => 1,
-      '#title' => $this->t('Maximum number of breadcrumbs'),
-      '#description' => $this->t("Stop adding parent references to the breadrumbs at this number of items. The default value, '-1' disables this feature."),
+      '#title' => $this->t('Maximum number of ancestor breadcrumbs'),
+      '#description' => $this->t("Stops adding ancestor references when the chain reaches this number. The count does not include the current node when enabled. The default value, '-1' disables this feature."),
     ];
 
     $form['includeSelf'] = [
diff --git a/modules/islandora_breadcrumbs/src/IslandoraBreadcrumbBuilder.php b/modules/islandora_breadcrumbs/src/IslandoraBreadcrumbBuilder.php
index d84b8c3c..5ed7f6d0 100644
--- a/modules/islandora_breadcrumbs/src/IslandoraBreadcrumbBuilder.php
+++ b/modules/islandora_breadcrumbs/src/IslandoraBreadcrumbBuilder.php
@@ -83,6 +83,7 @@ class IslandoraBreadcrumbBuilder implements BreadcrumbBuilderInterface {
     $nid = $route_match->getRawParameters()->get('node');
     $node = $this->nodeStorage->load($nid);
     $breadcrumb = new Breadcrumb();
+    $breadcrumb->addCacheableDependency($this->config);
     $breadcrumb->addLink(Link::createFromRoute($this->t('Home'), '<front>'));
 
     $chain = array_reverse($this->utils->findAncestors($node, $this->config->get('referenceFields'), $this->config->get('maxDepth')));