From 2f1251bf83ef79e028f9b5af8cb7a256e685c5bc Mon Sep 17 00:00:00 2001 From: krisbulman Date: Fri, 1 Jun 2012 11:56:25 -0300 Subject: [PATCH 1/5] CSS cleanup, markup change for list views --- .../css/islandora_basic_collection.base.css | 47 ++++++++++- .../css/islandora_basic_collection.theme.css | 80 +++++-------------- .../islandora-basic-collection-grid.tpl.php | 2 +- ...islandora-basic-collection-wrapper.tpl.php | 12 +-- .../theme/islandora-basic-collection.tpl.php | 33 +++----- 5 files changed, 85 insertions(+), 89 deletions(-) diff --git a/islandora_basic_collection/css/islandora_basic_collection.base.css b/islandora_basic_collection/css/islandora_basic_collection.base.css index 13dd8637..12e2e5b6 100644 --- a/islandora_basic_collection/css/islandora_basic_collection.base.css +++ b/islandora_basic_collection/css/islandora_basic_collection.base.css @@ -1,8 +1,51 @@ /* Document : islandora_basic_collection.base.css Created on : May 23, 2012, 11:22:04 AM - Description: - Purpose of the stylesheet follows. + Description: Base css, for structural layout, + positioning, and to generally make things function in + the most basic form. */ +/* List - Displays lists using a dt on the left and dd on the right */ +.islandora-basic-collection-list-item { + clear: both; + width: 100%; +} + +.islandora-basic-collection-list-item dl dt { + clear: left; + float: left; + padding: 3px 0 0; + text-align: center; + width: 100px; +} + +.islandora-basic-collection-list-item dl dd { + margin: 0 0 0 130px; +} + +/* Grid - Displays grid using dl formatted inline */ +.islandora-basic-collection-grid dl +{ + width: 20%; + min-width: 100px; + min-height: 180px; + display: -moz-inline-stack; + display: inline-block; + vertical-align: top; + margin: 1.5em 2%; + zoom: 1; + *display: inline; + _height: 180px; +} + +.islandora-basic-collection-grid dd +{ + margin: 0; + padding: 0; +} + +.islandora-basic-collection-display-switch { + float: right; +} diff --git a/islandora_basic_collection/css/islandora_basic_collection.theme.css b/islandora_basic_collection/css/islandora_basic_collection.theme.css index e814f526..cb204041 100644 --- a/islandora_basic_collection/css/islandora_basic_collection.theme.css +++ b/islandora_basic_collection/css/islandora_basic_collection.theme.css @@ -1,86 +1,46 @@ /* Document : islandora_basic_collection.theme Created on : May 23, 2012, 11:23:56 AM - Description: - Purpose of the stylesheet follows. + Description: Theme css, like margins, padding, borders, colors, etc */ +/* Make flexible and assure content doesn't go off the page */ .islandora-basic-collection { overflow: hidden; width: 100%; margin: 0 auto; } -.islandora-basic-collection-object { - margin: 1.5em auto 3em; -} - -.islandora-basic-collection-grid dl.islandora-basic-collection-object -{ - width: 20%; - min-width: 100px; - min-height: 180px; - display: -moz-inline-stack; - display: inline-block; - vertical-align: top; - margin: 1.5em 2%; - zoom: 1; - *display: inline; - _height: 180px; -} - -.islandora-basic-collection-grid .islandora-basic-collection-object dt img { - max-width: 100%; - *width: 100%; +/* Round borders on images */ +.islandora-basic-collection-object dt img { -webkit-border-radius: 5px; -moz-border-radius: 5px; border-radius: 5px; } -.islandora-basic-collection-grid .islandora-basic-collection-object dd -{ - margin: 0; - padding: 0; +/* Set space between objects */ +.islandora-basic-collection-object { + margin: 1.5em auto; } -/* to be moved to admin when it is added */ -#islandora-collection-deletion-form table th.select-all, -#islandora-collection-migrate-form table th.select-all { - width: 20px; +/* Set space between dd items */ +.islandora-basic-collection-object dd { + padding-top: 2px; + padding-bottom: 2px; } -/* the base css for lists is set in islandora, just adding details */ - -dl.islandora-basic-collection-thumb -{ - float: left; - width: 15%; - margin: 0; -} +/* LIST VIEW */ -.islandora-basic-collection-thumb dt, -.islandora-basic-collection-thumb dd -{ - margin: 0; +/* Borders to seperate collection objects */ +.islandora-basic-collection-list-item { + padding-bottom: 1.5em; + border-bottom: 1px solid #ddd; } -dl.islandora-basic-collection-fields -{ - float: right; - width: 83%; - border-top: 0px solid #ddd; - padding-left: 10px; -} - -.islandora-basic-collection-fields dt, -.islandora-basic-collection-fields dd -{ - border-top: 1px solid #ddd; -} -.islandora-basic-collection-fields dt.first, -.islandora-basic-collection-fields dd.first -{ - border-top: 1px solid #ddd; +/* to be moved to admin when it is added */ +#islandora-collection-deletion-form table th.select-all, +#islandora-collection-migrate-form table th.select-all { + width: 20px; } diff --git a/islandora_basic_collection/theme/islandora-basic-collection-grid.tpl.php b/islandora_basic_collection/theme/islandora-basic-collection-grid.tpl.php index 5635ebc9..c1489dde 100644 --- a/islandora_basic_collection/theme/islandora-basic-collection-grid.tpl.php +++ b/islandora_basic_collection/theme/islandora-basic-collection-grid.tpl.php @@ -23,7 +23,7 @@ ?> -
+
$value): ?>
diff --git a/islandora_basic_collection/theme/islandora-basic-collection-wrapper.tpl.php b/islandora_basic_collection/theme/islandora-basic-collection-wrapper.tpl.php index e1ca73c1..90f8666f 100644 --- a/islandora_basic_collection/theme/islandora-basic-collection-wrapper.tpl.php +++ b/islandora_basic_collection/theme/islandora-basic-collection-wrapper.tpl.php @@ -24,10 +24,10 @@ label); ?>
-
- - - - -
+
+ + + + +
\ No newline at end of file diff --git a/islandora_basic_collection/theme/islandora-basic-collection.tpl.php b/islandora_basic_collection/theme/islandora-basic-collection.tpl.php index 3fb1a4c2..33ad0462 100644 --- a/islandora_basic_collection/theme/islandora-basic-collection.tpl.php +++ b/islandora_basic_collection/theme/islandora-basic-collection.tpl.php @@ -23,31 +23,24 @@ ?> label); ?> -
+
-
-
-
-
-
-
\ No newline at end of file From d06288a2927db5afc0bb872d85badf28d138fbdb Mon Sep 17 00:00:00 2001 From: rwincewicz Date: Fri, 1 Jun 2012 13:35:42 -0300 Subject: [PATCH 2/5] Fixed error when deleting emtpy collections. PID is now displayed properly --- islandora_basic_collection/includes/delete_collection.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/islandora_basic_collection/includes/delete_collection.inc b/islandora_basic_collection/includes/delete_collection.inc index 6e4a4bb8..f7f26a03 100644 --- a/islandora_basic_collection/includes/delete_collection.inc +++ b/islandora_basic_collection/includes/delete_collection.inc @@ -21,7 +21,7 @@ function islandora_collection_deletion_form($form, &$form_state, $object) { $submit_text_message = ($table) ? "Delete selected objects" : "Delete collection"; $form = array(); - + $form['collection_delete']['titlebox'] = array( '#type' => 'item', '#title' => t("Delete objects from @collection_pid", array('@collection_pid' => $pid)), @@ -113,7 +113,7 @@ function islandora_collection_deletion_form_submit($form, &$form_state) { * @param string $pid */ function delete_root_collection($object) { - + $pid = $object->id; try { $object->repository->purgeObject($object->id); } catch (RepositoryException $e) { From b71b7a2d925fc798bbdd241239b5a5a5b1e2228e Mon Sep 17 00:00:00 2001 From: rwincewicz Date: Fri, 1 Jun 2012 13:46:24 -0300 Subject: [PATCH 3/5] Added meaningful message to manage collection policy when no content models exist --- .../includes/manage_policies.inc | 64 +++++++++++-------- 1 file changed, 36 insertions(+), 28 deletions(-) diff --git a/islandora_basic_collection/includes/manage_policies.inc b/islandora_basic_collection/includes/manage_policies.inc index 1fa3e68f..c5742303 100644 --- a/islandora_basic_collection/includes/manage_policies.inc +++ b/islandora_basic_collection/includes/manage_policies.inc @@ -27,8 +27,9 @@ function islandora_manage_policies_form($form, &$form_state, $collection_object) $item = $repository->getObject($content_model); $cm_name = $item->Label; $cm_options[$content_model] = $cm_name; + } catch (RepositoryException $e) { + } - catch(RepositoryException $e) {} } } @@ -71,36 +72,43 @@ function islandora_manage_policies_form($form, &$form_state, $collection_object) '#title' => t("Manage collection policy for @collection_title", array('@collection_title' => $collection_object->label)), ); - $form ['manage_collection_policy']['add']['content_model_to_add'] = array( - '#title' => "Choose content model", - '#type' => 'select', - '#options' => $new_options, - '#description' => t("Choose content model to add to this collection policy."), - ); + if (count($new_content_models) > 0) { + $form ['manage_collection_policy']['add']['content_model_to_add'] = array( + '#title' => "Choose content model", + '#type' => 'select', + '#options' => $new_options, + '#description' => t("Choose content model to add to this collection policy."), + ); - $form ['manage_collection_policy']['add']['new_cp_namespace'] = array( - '#title' => "Choose namespace", - '#type' => 'textfield', - '#size' => 15, - '#default_value' => $namespace, - '#description' => t("Choose namespace for objects in this collection associated with this content model"), - ); + $form['manage_collection_policy']['add']['new_cp_namespace'] = array( + '#title' => "Choose namespace", + '#type' => 'textfield', + '#size' => 15, + '#default_value' => $namespace, + '#description' => t("Choose namespace for objects in this collection associated with this content model"), + ); - $form['parent_collection'] = array( - '#type' => 'hidden', - '#value' => $collection_object->id, - ); + $form['parent_collection'] = array( + '#type' => 'hidden', + '#value' => $collection_object->id, + ); - $form['collection_pid'] = array( - '#type' => 'hidden', - '#value' => $collection_object->id, - ); + $form['collection_pid'] = array( + '#type' => 'hidden', + '#value' => $collection_object->id, + ); - $form['manage_collection_policy']['add']['submit'] = array( - '#type' => 'submit', - '#value' => t('Add content model to collection policy'), - '#id' => 'add_cm' - ); + $form['manage_collection_policy']['add']['submit'] = array( + '#type' => 'submit', + '#value' => t('Add content model to collection policy'), + '#id' => 'add_cm' + ); + } + else { + $form['manage_collection_policy']['no_content_models'] = array( + '#markup' => t('No content models available to add!'), + ); + } if (count($current_models_in_policy) > 0) { $form['manage_collection_policy']['remove'] = array( @@ -140,7 +148,7 @@ function islandora_manage_policies_form_submit($form, &$form_state) { module_load_include('module', 'islandora', 'islandora'); $collection_pid = $form_state['values']['parent_collection']; $collection_object = islandora_object_load($collection_pid); - + $policy = $collection_object->getDatastream(variable_get('Islandora_Collection_Policy_DSID', 'COLLECTION_POLICY')); $collection_policy = ' From 43ff94495001014a4423d2989a855a3a8444ed32 Mon Sep 17 00:00:00 2001 From: krisbulman Date: Fri, 1 Jun 2012 13:49:10 -0300 Subject: [PATCH 4/5] updated basic image display --- .../css/islandora_basic_image.theme.css | 33 +++++++++++-------- .../islandora-basic-image.tpl.php | 20 ++++++----- 2 files changed, 31 insertions(+), 22 deletions(-) diff --git a/islandora_basic_image/css/islandora_basic_image.theme.css b/islandora_basic_image/css/islandora_basic_image.theme.css index 93a8db89..f62b37bf 100644 --- a/islandora_basic_image/css/islandora_basic_image.theme.css +++ b/islandora_basic_image/css/islandora_basic_image.theme.css @@ -1,14 +1,22 @@ /* Document : islandora_basic_collection.theme Created on : May 23, 2012, 11:23:56 AM - Description: - Purpose of the stylesheet follows. + Description: The basic image page is a simple flexible layout page + that breaks down to two columns when 2 sidebars are visible */ -.islandora-basic-image-content, -.islandora-basic-image-sidebar { - display: inline; - position: relative; +.islandora-basic-image-content { + background-color: #F2F2F2; + border: 1px solid #ddd; + -webkit-border-radius: 5px; + -moz-border-radius: 5px; + border-radius: 5px; + padding: 15px; +} + +.islandora-basic-image-content img { + margin: 0; + display: block; } .islandora-basic-image-metadata { @@ -42,9 +50,6 @@ dl.islandora-basic-image-fields { border-top:0; } -.islandora-basic-image-sidebar, -.islandora-basic-image-sidebar, -body.one-sidebar .islandora-basic-image-sidebar, body.two-sidebars .islandora-basic-image-sidebar { clear: both; width: 100%; @@ -53,15 +58,17 @@ body.two-sidebars .islandora-basic-image-sidebar { @media all and (min-width: 768px) { body.no-sidebars .islandora-basic-image-content { - width: 60%; - padding: 0 20px 0 0; + width: 65%; float: left; /* LTR */ - margin-top: 1em; + } + + body.no-sidebars .islandora-basic-image-sidebar { + padding-left: 20px; } body.no-sidebars .islandora-basic-image-sidebar { float: right; /* LTR */ - width: 40%; + width: 35%; clear: none; } diff --git a/islandora_basic_image/islandora-basic-image.tpl.php b/islandora_basic_image/islandora-basic-image.tpl.php index 1cce0bfa..561c8a63 100644 --- a/islandora_basic_image/islandora-basic-image.tpl.php +++ b/islandora_basic_image/islandora-basic-image.tpl.php @@ -26,22 +26,24 @@
-
- - TRUE)); ?> +
+ +
+ + TRUE)); ?> - + +
-
-

+

- +
-

In Collections

+

In Collections

    $value): ?>
  • @@ -50,7 +52,7 @@
- +