From a250c2ac7883d7ba235b0e43b2e978e51e18dae9 Mon Sep 17 00:00:00 2001
From: Adam <adam-vessey@users.noreply.github.com>
Date: Thu, 15 Sep 2022 12:52:51 -0300
Subject: [PATCH] Fix/schemas (#898)

* Define schemas that should be defined.

Came out of the starter site project, running "config_inspector" flagged
a number of things.

* Avoid the deprecated sequence specification.

* Bad assumption on my part...

... Seeing the name and the module, figured this schema was just
misplaced... Appears that the `islandora_image` thing is indeed in
`islandora` proper.
---
 config/schema/islandora.schema.yml            | 78 +++++++++++++++++++
 .../config/schema/islandora_audio.schema.yml  |  3 +
 .../config/schema/islandora_iiif.schema.yml   |  8 ++
 .../config/schema/islandora_video.schema.yml  |  3 +
 4 files changed, 92 insertions(+)

diff --git a/config/schema/islandora.schema.yml b/config/schema/islandora.schema.yml
index c98679eb..e85d5739 100644
--- a/config/schema/islandora.schema.yml
+++ b/config/schema/islandora.schema.yml
@@ -87,6 +87,14 @@ condition.plugin.node_has_term:
     logic:
       type: string
       label: 'Logic (AND or OR)'
+    tids:
+      type: sequence
+      sequence:
+        type: mapping
+        mapping:
+          target_id:
+            type: integer
+            label: The target taxonomy term IDs
 
 condition.plugin.node_has_parent:
   type: condition.plugin
@@ -158,6 +166,76 @@ condition.plugin.node_had_namespace:
     pid_field:
       type: ignore
       label: 'PID field'
+      
 field.formatter.settings.islandora_image:
   type: field.formatter.settings.image
   label: 'Islandora image field display format settings'
+
+condition.plugin.islandora_entity_bundle:
+  type: condition.plugin
+  mapping:
+    bundles:
+      type: sequence
+      sequence:
+        type: string
+
+condition.plugin.media_source_mimetype:
+  type: condition.plugin
+  mapping:
+    mimetype:
+      type: string
+
+reaction.plugin.alter_jsonld_type:
+  type: islandora.reaction_plugin_with_saved
+  mapping:
+    source_field:
+      type: string
+
+islandora.reaction_plugin_with_saved:
+  type: reaction.plugin
+  mapping:
+    saved:
+      type: boolean
+      label: Default config upstream; however, left undefined in the schema.
+
+reaction.plugin.islandora_map_uri_predicate:
+  type: islandora.reaction_plugin_with_saved
+  mapping:
+    drupal_uri_predicate:
+      type: string
+
+reaction.plugin.view_mode_alter:
+  type: islandora.reaction_plugin_with_saved
+  mapping:
+    mode:
+      type: string
+      label: The view mode to which to switch
+
+islandora.reaction.actions:
+  type: islandora.reaction_plugin_with_saved
+  mapping:
+    actions:
+      type: sequence
+      sequence:
+        type: string
+
+reaction.plugin.index:
+  type: islandora.reaction.actions
+
+reaction.plugin.delete:
+  type: islandora.reaction.actions
+
+reaction.plugin.derivative:
+  type: islandora.reaction.actions
+
+field.widget.settings.media_track:
+  type: field.widget.settings.file_generic
+
+field.field_settings.media_track:
+  type: field.field_settings.file
+  mapping:
+    languages:
+      type: string
+
+field.storage_settings.media_track:
+  type: field.storage_settings.file
diff --git a/modules/islandora_audio/config/schema/islandora_audio.schema.yml b/modules/islandora_audio/config/schema/islandora_audio.schema.yml
index 5f09740a..82b08088 100644
--- a/modules/islandora_audio/config/schema/islandora_audio.schema.yml
+++ b/modules/islandora_audio/config/schema/islandora_audio.schema.yml
@@ -29,3 +29,6 @@ action.configuration.generate_audio_derivative:
     path:
       type: text
       label: 'File path with extension'
+
+field.formatter.settings.islandora_file_audio:
+  type: field.formatter.settings.file_audio
diff --git a/modules/islandora_iiif/config/schema/islandora_iiif.schema.yml b/modules/islandora_iiif/config/schema/islandora_iiif.schema.yml
index 6ef42bc4..fc62c5c4 100644
--- a/modules/islandora_iiif/config/schema/islandora_iiif.schema.yml
+++ b/modules/islandora_iiif/config/schema/islandora_iiif.schema.yml
@@ -5,3 +5,11 @@ islandora_iiif.settings:
     iiif_server:
       type: string
       label: 'IIIF Server Url'
+
+views.style.iiif_manifest:
+  type: views_style
+  mapping:
+    iiif_tile_field:
+      type: sequence
+      sequence:
+        type: string
diff --git a/modules/islandora_video/config/schema/islandora_video.schema.yml b/modules/islandora_video/config/schema/islandora_video.schema.yml
index b1d72d7f..01d28481 100644
--- a/modules/islandora_video/config/schema/islandora_video.schema.yml
+++ b/modules/islandora_video/config/schema/islandora_video.schema.yml
@@ -29,3 +29,6 @@ action.configuration.generate_video_derivative:
     path:
       type: text
       label: 'File path with extension'
+
+field.formatter.settings.islandora_file_video:
+  type: field.formatter.settings.file_video