diff --git a/includes/utilities.inc b/includes/utilities.inc index ffa0244b..971cfaac 100644 --- a/includes/utilities.inc +++ b/includes/utilities.inc @@ -916,9 +916,9 @@ function islandora_as_renderable_array(&$markup_array) { /** * Creates and returns a singleton of tuque if one does not already exist. * - * @param object $user + * @param object $user * User who created the request. - * @param object $url + * @param object $url * URL to Fedora. * * @return IslandoraTuque diff --git a/islandora.module b/islandora.module index cb9f38ec..727b06b0 100644 --- a/islandora.module +++ b/islandora.module @@ -998,36 +998,6 @@ function islandora_get_tuque_connection($new_user = NULL, $url = NULL) { global $user; - // $user_for_tuque = NULL; - // - // if TUQUE DOES NOT EXIST { - // if PROVIDED USER IS NOT NULL { - // MAKE TUQUE WITH PROVIDED USER - // } - // else - // { - // MAKE TUQUE WITH GLOBAL USER - // } - // } - // else { - // if PROVIDED USER IS NOT NULL { - // if PROVIDED USER IS NOT TUQUE'S USER { - // MAKE TUQUE WITH PROVIDED USER - // } - // else { - // LEAVE TUQUE ALONE - // } - // } - // else { - // if GLOBAL USER IS NOT TUQUE'S USER { - // MAKE TUQUE WITH GLOBAL USER - // } - // else { - // LEAVE TUQUE ALONE - // } - // } - // } - // If tuque is NULL. if (!$tuque) { // If the provided user is not null, pass it along to Tuque. @@ -1067,6 +1037,17 @@ function islandora_get_tuque_connection($new_user = NULL, $url = NULL) { return $tuque; } +/** + * Creates a singleton of tuque. + * + * @param object $user + * The user to create tuque with. + * @param string $url + * The URL to create tuque with. + * + * @return IslandoraTuque + * The singleton tuque object. + */ function islandora_make_tuque($user, $url) { if (IslandoraTuque::exists()) { try { diff --git a/tests/islandora_tuque.test b/tests/islandora_tuque.test index 13b5eff9..dab3117b 100644 --- a/tests/islandora_tuque.test +++ b/tests/islandora_tuque.test @@ -58,93 +58,90 @@ class IslandoraTuqueTestCase extends IslandoraWebTestCase { } - /** - * Tests that tuque does not exist and the user is not null. - */ - public function testTuqueDoesNotExistAndUserIsNotNull() { - $tuque = &drupal_static(__FUNCTION__); - $tuque = NULL; - - $user_to_provide = user_load(0); +/** + * Tests that tuque does not exist and the user is not null. + */ +public function testTuqueDoesNotExistAndUserIsNotNull() { + $tuque = &drupal_static(__FUNCTION__); + $tuque = NULL; - $new_tuque = islandora_get_tuque_connection($user_to_provide); - $new_tuque_user_name = $new_tuque->connection->username; + $user_to_provide = user_load(0); - assertNotNull($new_tuque); - assertNotNull($tuque); - assertEqual($user_to_provide->name, $new_tuque_user_name); - } + $new_tuque = islandora_get_tuque_connection($user_to_provide); + $new_tuque_user_name = $new_tuque->connection->username; - /** - * Tests that tuque does not exist and the user is null. - */ - public function testTuqueDoesNotExistAndUserIsNull() { - $tuque = &drupal_static(__FUNCTION__); - $tuque = NULL; + assertNotNull($new_tuque); + assertNotNull($tuque); + assertEqual($user_to_provide->name, $new_tuque_user_name); +} - $user_to_provide = NULL; +/** + * Tests that tuque does not exist and the user is null. + */ +public function testTuqueDoesNotExistAndUserIsNull() { + $tuque = &drupal_static(__FUNCTION__); + $tuque = NULL; - $new_tuque = islandora_get_tuque_connection($user_to_provide); - $new_tuque_user_name = $new_tuque->connection->username; + $user_to_provide = NULL; - global $user; + $new_tuque = islandora_get_tuque_connection($user_to_provide); + $new_tuque_user_name = $new_tuque->connection->username; - assertNotNull($new_tuque); - assertNotNull($tuque); - assertEqual($new_tuque_user_name, $user); - } + global $user; - /** - * Test that tuque exists and the user is not null and the user is not tuque's - * user. - */ - public function testTuqueExistsAndUserIsNotNullAndUserIsNotTuquesUser() { - $tuque = &drupal_static(__FUNCTION__); - $user_to_provide = user_load(0); - $new_tuque = islandora_get_tuque_connection($user_to_provide); - - assertNotNull($new_tuque); - assertNotNull($tuque); - assertNotEqual($user_to_provide->name, $new_tuque->connection->username); - } + assertNotNull($new_tuque); + assertNotNull($tuque); + assertEqual($new_tuque_user_name, $user); +} - /** - * Tests that tuque exists and the user is not null and the user is tuque's user - */ - public function testTuqueExistsAndUserIsNotNullAndUserIsTuquesUser() { - $tuque = &drupal_static(__FUNCTION__); - $new_tuque = islandora_get_tuque_connection($tuque->connection->username); +/** + * Test that tuque exists, the user is not null, the user is not tuque's user. + */ +public function testTuqueExistsAndUserIsNotNullAndUserIsNotTuquesUser() { + $tuque = &drupal_static(__FUNCTION__); + $user_to_provide = user_load(0); + $new_tuque = islandora_get_tuque_connection($user_to_provide); + + assertNotNull($new_tuque); + assertNotNull($tuque); + assertNotEqual($user_to_provide->name, $new_tuque->connection->username); +} - assertNotNull($new_tuque); - assertNotNull($tuque); - assertEqual($tuque->connection->username, $new_tuque->connection->username); - } +/** + * Tests that tuque exists, the user is not null, the user is tuque's user. + */ +public function testTuqueExistsAndUserIsNotNullAndUserIsTuquesUser() { + $tuque = &drupal_static(__FUNCTION__); + $new_tuque = islandora_get_tuque_connection($tuque->connection->username); - /** - * Tests that tuque exists and the user is null and the global user is not - * tuque's user. - */ - public function testTuqueExistsAndUserIsNullAndGlobalUserIsNotTuquesUser() { - $tuque = &drupal_static(__FUNCTION__); - global $user = NULL; - $new_tuque = islandora_get_tuque_connection($user); - - assertNotNull($new_tuque); - assertNotNull($tuque); - assertNotEqual($new_tuque->connection->username, $user); - } + assertNotNull($new_tuque); + assertNotNull($tuque); + assertEqual($tuque->connection->username, $new_tuque->connection->username); +} - /** - * Tests that tuque exists and the user is null and the global user is tuque's - * user. - */ - public function testTuqueExistsAndUserIsNullAndGlobalUserIsTuquesUser() { - $tuque = &drupal_static(__FUNCTION__); - global $user = $tuque->connection->username; - $new_tuque = islandora_get_tuque_connection($user); - - assertNotNull($new_tuque); - assertNotNull($tuque); - assertEqual($new_tuque->connection->username, $user); - } +/** + * Tests that tuque exists, the user is null, global user is not tuque's user. + */ +public function testTuqueExistsAndUserIsNullAndGlobalUserIsNotTuquesUser() { + $tuque = &drupal_static(__FUNCTION__); + global $user = NULL; + $new_tuque = islandora_get_tuque_connection($user); + + assertNotNull($new_tuque); + assertNotNull($tuque); + assertNotEqual($new_tuque->connection->username, $user); +} +/** + * Tests that tuque exists, the user is null, global user is tuque's user. + */ +public function testTuqueExistsAndUserIsNullAndGlobalUserIsTuquesUser() { + $tuque = &drupal_static(__FUNCTION__); + global $_islandora_user; + $_islandora_user = $tuque->connection->username; + $new_tuque = islandora_get_tuque_connection($user); + + assertNotNull($new_tuque); + assertNotNull($tuque); + assertEqual($new_tuque->connection->username, $user); +}