From 14a6715696144baf06d87029390d7c328257afb7 Mon Sep 17 00:00:00 2001
From: Ant Brown <ant@catalyst.net.nz>
Date: Wed, 10 Apr 2024 16:10:25 +1200
Subject: [PATCH] Only cache terms that exist (Islandora#2272)

---
 src/IslandoraUtils.php | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/src/IslandoraUtils.php b/src/IslandoraUtils.php
index fb61d8b3..a026ac18 100644
--- a/src/IslandoraUtils.php
+++ b/src/IslandoraUtils.php
@@ -301,15 +301,14 @@ class IslandoraUtils {
     if (!empty($results)) {
       $term = $this->entityTypeManager->getStorage('taxonomy_term')
         ->load(reset($results));
+      $this->cache->set(
+        $cid,
+        $term,
+        CacheBackendInterface::CACHE_PERMANENT,
+        Cache::mergeTags(array_merge($term->getCacheTags(), ['user:' . $this->currentUser->id()]))
+      );
     }
 
-    $this->cache->set(
-      $cid,
-      $term,
-      CacheBackendInterface::CACHE_PERMANENT,
-      Cache::mergeTags(array_merge($term->getCacheTags(), ['user:' . $this->currentUser->id()]))
-    );
-
     return $term;
   }