From c3519035bfe091d8cd5756fae4c993e9620ecd12 Mon Sep 17 00:00:00 2001
From: David Wilcox <dwilcox@upei.ca>
Date: Mon, 17 Dec 2012 13:35:33 -0400
Subject: [PATCH] Changed object management permissions

Changed 'FEDORA_MODIFY_STATE' to 'FEDORA_MANAGE_PROPERTIES' and fixed
'View object management tabs' permission to correctly depend on
'FEDORA_MANAGE'.
---
 islandora.module | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/islandora.module b/islandora.module
index 5e6fd7cf..f8673546 100644
--- a/islandora.module
+++ b/islandora.module
@@ -31,7 +31,7 @@ define('FEDORA_METADATA_EDIT', 'edit fedora metadata');
 define('FEDORA_ADD_DS', 'add fedora datastreams');
 define('FEDORA_INGEST', 'ingest fedora objects');
 define('FEDORA_PURGE', 'delete fedora objects and datastreams');
-define('FEDORA_MODIFY_STATE', 'modify fedora state');
+define('FEDORA_MANAGE_PROPERTIES', 'manage object properties');
 define('FEDORA_MANAGE', 'manage fedora items');
 
 // Hooks
@@ -108,7 +108,7 @@ function islandora_menu() {
     'page arguments' => array(2),
     'type' => MENU_LOCAL_TASK,
     'access callback' => 'islandora_object_access_callback',
-    'access arguments' => array(FEDORA_MODIFY_STATE, 2),
+    'access arguments' => array(FEDORA_MANAGE, 2),
   );
   $items['islandora/object/%islandora_object/manage/datastreams'] = array(
     'title' => 'Datastreams',
@@ -122,7 +122,7 @@ function islandora_menu() {
     'page arguments' => array('islandora_object_properties_form', 2),
     'type' => MENU_LOCAL_TASK,
     'access callback' => 'islandora_object_access_callback',
-    'access arguments' => array(FEDORA_MODIFY_STATE, 2),
+    'access arguments' => array(FEDORA_MANAGE_PROPERTIES, 2),
     'weight' => -5,
   );
   $items['islandora/object/%islandora_object/delete'] = array(
@@ -268,9 +268,9 @@ function islandora_permission() {
       'title' => t('Permanently remove objects from the repository'),
       'description' => t('Permanently remove objects from the repository.')
     ),
-    FEDORA_MODIFY_STATE => array(
-      'title' => t('Change repository object states'),
-      'description' => t('Change the state of objects in the repository (e.g. from Active to Inactive).')
+    FEDORA_MANAGE_PROPERTIES => array(
+      'title' => t('Manage object properties'),
+      'description' => t('Modify object labels, owner IDs, and states.')
     ),
     FEDORA_MANAGE => array(
       'title' => t('View object management tabs'),